Bug 57756 - [llvmpipe] piglit arb_sampler_objects-srgb-decode regression
Summary: [llvmpipe] piglit arb_sampler_objects-srgb-decode regression
Status: RESOLVED DUPLICATE of bug 57699
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-01 06:52 UTC by Vinson Lee
Modified: 2012-12-03 14:58 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Vinson Lee 2012-12-01 06:52:12 UTC
mesa: da7029dcb498f80d1837323038617b49cc28431f (master)

Run piglit arb_sampler_objects-srgb-decode on llvmpipe.

$ ./bin/arb_sampler_objects-srgb-decode -auto
Probe at (0,0)
  Expected: 0.033105 0.132868 0.318547 0.800000
  Observed: 0.200000 0.400000 0.600000 0.800000
Probe at (0,8)
  Expected: 0.033105 0.132868 0.318547 0.800000
  Observed: 0.200000 0.400000 0.600000 0.800000
PIGLIT: {'result': 'fail' }

9f06061d50f90bf425a5337cea1b0adb94a46d25 is the first bad commit
commit 9f06061d50f90bf425a5337cea1b0adb94a46d25
Author: José Fonseca <jfonseca@vmware.com>
Date:   Wed Nov 28 19:20:18 2012 +0000

    util/u_format: Kill util_format_is_array().

    It is buggy (it was giving wrong results for some of the formats with
    padding), and util_format_description::is_array already does precisely
    what's intended.

    Reviewed-by: Roland Scheidegger <sroland@vmware.com>

:040000 040000 acbb7501279a631c0f3e26c21f98e493fc23d551 23f59be31e2e9bdcc534e2745f0505938888bce2 M      src
bisect run success
Comment 1 Jose Fonseca 2012-12-03 14:58:01 UTC
Fixed with

commit 041966801ec87e3bf32913e43d6882eca9434695
Author: Roland Scheidegger <sroland@vmware.com>
Date:   Sat Dec 1 17:04:54 2012 +0100

    gallivm: fix srgb format fetch
    
    we need to rely on util code for fetching those, just like before
    9f06061d50f90bf425a5337cea1b0adb94a46d25.
    Fixes bugs 57699 and 57756.
    
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Reviewed-by: José Fonseca <jfonseca@vmware.com>

*** This bug has been marked as a duplicate of bug 57699 ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.