| Summary: | "Log" option for xorg.conf undocumented, and needs to set XLOG_FLUSH as well as XLOG_SYNC | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Bill Crawford <billcrawford1970> |
| Component: | Server/General | Assignee: | Xorg Project Team <xorg-team> |
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | high | CC: | erik.andren |
| Version: | unspecified | Keywords: | patch |
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Added patch keyword Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future. (In reply to comment #0) > hw/xfree86/common/xf86Config.c checks for a "Log" server flag, and accepts > values "flush" or "sync". "sync" sets XLOG_SYNC but not XLOG_FLUSH. *but* > LogVWrite in os/log.c only checks logSync is logFlush is also set. Quickest > solution I can think of: > the syncing was fixed in 881a620b4d6ea7a54af14c8f8fbe6924c9aa9291. Option "Log" now added to xorg.conf(5): commit fd97ff1bdd30c358525068a4c833f681e00719a2 Author: Julien Cristau <jcristau@debian.org> Date: Sat Oct 25 22:54:15 2008 +0200 Bug#5851: Document the "Log" option in xorg.conf(5) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
hw/xfree86/common/xf86Config.c checks for a "Log" server flag, and accepts values "flush" or "sync". "sync" sets XLOG_SYNC but not XLOG_FLUSH. *but* LogVWrite in os/log.c only checks logSync is logFlush is also set. Quickest solution I can think of: --- hw/xfree86/common/xf86Config.c.orig 2006-02-09 18:55:08.000000000 +0000 +++ hw/xfree86/common/xf86Config.c 2006-02-09 18:56:46.000000000 +0000 @@ -955,6 +955,7 @@ } else if (!xf86NameCmp(s,"sync")) { xf86Msg(X_CONFIG, "Syncing logfile enabled\n"); xf86Info.log = LogSync; + LogSetParameter(XLOG_FLUSH, TRUE); LogSetParameter(XLOG_SYNC, TRUE); } else { xf86Msg(X_WARNING,"Unknown Log option\n");