Bug 5851 - "Log" option for xorg.conf undocumented, and needs to set XLOG_FLUSH as well as XLOG_SYNC
Summary: "Log" option for xorg.conf undocumented, and needs to set XLOG_FLUSH as well ...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2006-02-10 05:52 UTC by Bill Crawford
Modified: 2008-10-25 14:05 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Bill Crawford 2006-02-10 05:52:38 UTC 
hw/xfree86/common/xf86Config.c checks for a "Log" server flag, and accepts
values "flush" or "sync". "sync" sets XLOG_SYNC but not XLOG_FLUSH. *but*
LogVWrite in os/log.c only checks logSync is logFlush is also set. Quickest
solution I can think of:

--- hw/xfree86/common/xf86Config.c.orig 2006-02-09 18:55:08.000000000 +0000
+++ hw/xfree86/common/xf86Config.c      2006-02-09 18:56:46.000000000 +0000
@@ -955,6 +955,7 @@
            } else if (!xf86NameCmp(s,"sync")) {
                xf86Msg(X_CONFIG, "Syncing logfile enabled\n");
                xf86Info.log = LogSync;
+               LogSetParameter(XLOG_FLUSH, TRUE);
                LogSetParameter(XLOG_SYNC, TRUE);
            } else {
                xf86Msg(X_WARNING,"Unknown Log option\n");
Comment 1 Erik Andren 2006-04-19 16:35:11 UTC 
Added patch keyword
Comment 2 Daniel Stone 2007-02-27 01:30:24 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 3 Julien Cristau 2008-10-25 14:05:28 UTC 
(In reply to comment #0)
> hw/xfree86/common/xf86Config.c checks for a "Log" server flag, and accepts
> values "flush" or "sync". "sync" sets XLOG_SYNC but not XLOG_FLUSH. *but*
> LogVWrite in os/log.c only checks logSync is logFlush is also set. Quickest
> solution I can think of:
> 
the syncing was fixed in 881a620b4d6ea7a54af14c8f8fbe6924c9aa9291.

Option "Log" now added to xorg.conf(5):
commit fd97ff1bdd30c358525068a4c833f681e00719a2
Author: Julien Cristau <jcristau@debian.org>
Date:   Sat Oct 25 22:54:15 2008 +0200

    Bug#5851: Document the "Log" option in xorg.conf(5)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.