Summary: | Add support for GL_EXT_bindable_uniform - Dungeon Defenders fails to launch crash | ||
---|---|---|---|
Product: | Mesa | Reporter: | Kenney Phillis Jr <kphillisjr> |
Component: | Mesa core | Assignee: | mesa-dev |
Status: | RESOLVED NOTOURBUG | QA Contact: | |
Severity: | enhancement | ||
Priority: | medium | CC: | ruthubuntu |
Version: | git | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
URL: | https://bugzilla.icculus.org/show_bug.cgi?id=5823 | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | Hack to pretend EXT_bindable_uniform is supported |
Description
Kenney Phillis Jr
2012-12-25 04:26:06 UTC
Created attachment 72119 [details]
Hack to pretend EXT_bindable_uniform is supported
It looks like most of Dungeon Defenders' shaders try to enable EXT_bindable_uniform via:
#extension GL_EXT_bindable_uniform : require
but all of the shaders also contain "/*ndabl*/uniform" instead of "bindable uniform", which suggests that the game /used/ to use the extension, but doesn't now. It's just asking for functionality it doesn't need.
I commented on the upstream bug (linked from the URL field here); hopefully icculus can fix that. In the meantime, I've also attached a patch that makes Mesa pretend to support the extension, which allows the game to run. (It doesn't actually implement anything.)
On i965/Ivybridge, this makes it draw the splash screen, but it then hits an assertion failure. I'll look into that.
Dungeon Defenders now appears to be playable on Ivybridge. You need the attached patch (pending an upstream fix) and this one as well: http://lists.freedesktop.org/archives/mesa-dev/2012-December/032011.html Not sure about other drivers. It's possible that other apps have similar errors. It may be better to have a switch that will degrade errors to warnings for 'required' extensions that we don't support. At some point, someone is going to see this one-off, say "WTF?", and probably remove it. This should've been closed a long time ago :) Ryan Gordon fixed Dungeon Defenders clear back in March, if not earlier. The latest Steam builds work fine, as do the Humble Bundle builds. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.