Bug 58734 - Add support for GL_EXT_bindable_uniform - Dungeon Defenders fails to launch crash
Summary: Add support for GL_EXT_bindable_uniform - Dungeon Defenders fails to launch c...
Status: RESOLVED NOTOURBUG
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium enhancement
Assignee: mesa-dev
QA Contact:
URL: https://bugzilla.icculus.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-25 04:26 UTC by Kenney Phillis Jr
Modified: 2013-07-30 15:36 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Hack to pretend EXT_bindable_uniform is supported (2.91 KB, text/plain)
2012-12-26 04:29 UTC, Kenneth Graunke
Details

Description Kenney Phillis Jr 2012-12-25 04:26:06 UTC
The recently released version of Dungeon defenders for linux is poor at best. Currently the game fails to launch due to missing extensions... For now, the first extension missing is GL_EXT_bindable_uniform.
Comment 1 Kenneth Graunke 2012-12-26 04:29:23 UTC
Created attachment 72119 [details]
Hack to pretend EXT_bindable_uniform is supported

It looks like most of Dungeon Defenders' shaders try to enable EXT_bindable_uniform via:

#extension GL_EXT_bindable_uniform : require

but all of the shaders also contain "/*ndabl*/uniform" instead of "bindable uniform", which suggests that the game /used/ to use the extension, but doesn't now.  It's just asking for functionality it doesn't need.

I commented on the upstream bug (linked from the URL field here); hopefully icculus can fix that.  In the meantime, I've also attached a patch that makes Mesa pretend to support the extension, which allows the game to run.  (It doesn't actually implement anything.)

On i965/Ivybridge, this makes it draw the splash screen, but it then hits an assertion failure.  I'll look into that.
Comment 2 Kenneth Graunke 2012-12-26 05:00:36 UTC
Dungeon Defenders now appears to be playable on Ivybridge.

You need the attached patch (pending an upstream fix) and this one as well:
http://lists.freedesktop.org/archives/mesa-dev/2012-December/032011.html

Not sure about other drivers.
Comment 3 Ian Romanick 2012-12-27 08:21:30 UTC
It's possible that other apps have similar errors.  It may be better to have a switch that will degrade errors to warnings for 'required' extensions that we don't support.

At some point, someone is going to see this one-off, say "WTF?", and probably remove it.
Comment 4 Kenneth Graunke 2013-07-30 15:36:10 UTC
This should've been closed a long time ago :)

Ryan Gordon fixed Dungeon Defenders clear back in March, if not earlier.  The latest Steam builds work fine, as do the Humble Bundle builds.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.