Bug 5921

Created attachment 4640 [details]
XGI 8300 source code for Linux

XGI 8300 source code for Linux

Looks like the license for this driver is missing. :-(

Jong Lin:

Can you please add the missing driver licensing which was requested above?
It should be MIT/X11 style license for inclusion into the tree.

Hope this helps.

Ping to Jong Lin about this bug!

(In reply to comment #4)
> Ping to Jong Lin about this bug!

Add the following license declaration for each source file. Right?

 * Copyright (C) 2004-2008 by eXtreme Graphice Innovation, Taiwan.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1) Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 * 2) Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in the
 *    documentation and/or other materials provided with the distribution.
 * 3) The name of the author may not be used to endorse or promote products
 *    derived from this software without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

This appears to be the license, which is also used by Thomas Winischhofer in 
the sis/sisusb driver. So I suggest to add a copyright line for him, if your 
driver is based on his sis driver.

 * Copyright (C) 200X-200Y by Thomas Winischhofer, Vienna, Austria.

(In reply to comment #6)
> This appears to be the license, which is also used by Thomas Winischhofer in 
> the sis/sisusb driver. So I suggest to add a copyright line for him, if your 
> driver is based on his sis driver.
>  * Copyright (C) 200X-200Y by Thomas Winischhofer, Vienna, Austria.

Thanks for your quick response. As I know, the code of 8300 is totally 
developed by XGI but being not based upon Thomas's code. So, we don't need to 
declare   * Copyright (C) 200X-200Y by Thomas Winischhofer, Vienna, Austria. Is 
it right?

Ok. But then you're free to use any X.Org compliant license to choose. I 
suggest to use the license, which is also used i810 and radeon driver.

/*
 * Copyright (C) 2004-2008 by eXtreme Graphice Innovation, Taiwan.
 *
 * All Rights Reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining
 * a copy of this software and associated documentation files (the
 * "Software"), to deal in the Software without restriction, including
 * without limitation on the rights to use, copy, modify, merge,
 * publish, distribute, sublicense, and/or sell copies of the Software,
 * and to permit persons to whom the Software is furnished to do so,
 * subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the
 * next paragraph) shall be included in all copies or substantial
 * portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 * NON-INFRINGEMENT.  IN NO EVENT SHALL ATI, VA LINUX SYSTEMS AND/OR
 * THEIR SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
 * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 */

(In reply to comment #8)
> Ok. But then you're free to use any X.Org compliant license to choose. I 
> suggest to use the license, which is also used i810 and radeon driver.
> /*
>  * Copyright (C) 2004-2008 by eXtreme Graphice Innovation, Taiwan.
>  *
>  * All Rights Reserved.
>  *
>  * Permission is hereby granted, free of charge, to any person obtaining
>  * a copy of this software and associated documentation files (the
>  * "Software"), to deal in the Software without restriction, including
>  * without limitation on the rights to use, copy, modify, merge,
>  * publish, distribute, sublicense, and/or sell copies of the Software,
>  * and to permit persons to whom the Software is furnished to do so,
>  * subject to the following conditions:
>  *
>  * The above copyright notice and this permission notice (including the
>  * next paragraph) shall be included in all copies or substantial
>  * portions of the Software.
>  *
>  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>  * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>  * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>  * NON-INFRINGEMENT.  IN NO EVENT SHALL ATI, VA LINUX SYSTEMS AND/OR
>  * THEIR SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>  * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
>  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>  * DEALINGS IN THE SOFTWARE.
>  */

Thanks for your suggestion, Stefan. We'll review it and post the source again 
ASAP.

(In reply to comment #5)
> (In reply to comment #4)
> > Ping to Jong Lin about this bug!
> 
> Add the following license declaration for each source file. Right?
> 
>  * Copyright (C) 2004-2008 by eXtreme Graphice Innovation, Taiwan.
>  *
>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that the following conditions
>  * are met:
>  * 1) Redistributions of source code must retain the above copyright
>  *    notice, this list of conditions and the following disclaimer.

On first read, this clause seems ok.

>  * 2) Redistributions in binary form must reproduce the above copyright
>  *    notice, this list of conditions and the following disclaimer in the
>  *    documentation and/or other materials provided with the distribution.

This clause sounds like the XFree86 license which was the catalyst for
X.Org forking the codebase - to avoid having to individually list a bunch
of extra copyright stuff just for one piece of software to global
distribution documentation.

Why do people feel the need to make life difficult on Linux distributors
in this manner.  How exactly is the stock MIT or BSD license inadequate
really?

>  * 3) The name of the author may not be used to endorse or promote products
>  *    derived from this software without specific prior written permission.

This clause sounds fine.

If clause 2 gets added to anything, I think we should reject the code until
a better license, preferably stock standard MIT/X11 is provided for this,
so that distributors do not have to jump through hoops to appease a license
for a single driver.  It's easier to just not ship a driver than to jump
through legal hoops for one vendor IMHO.

Do hardware vendors want to have their drivers included with all OS's by
default, or do they want to make life difficult on distribution vendors,
and possibly have their drivers excluded?

Makes me wonder.

(In reply to comment #10)
> >  * 2) Redistributions in binary form must reproduce the above copyright
> >  *    notice, this list of conditions and the following disclaimer in the
> >  *    documentation and/or other materials provided with the distribution.
> 
> This clause sounds like the XFree86 license which was the catalyst for
> X.Org forking the codebase - to avoid having to individually list a bunch
> of extra copyright stuff just for one piece of software to global
> distribution documentation.

Except we already do this upstream, in the release notes, for basically everyone
with a copyright statement in the source, regardless of whether the covering
license requires it.  We _should_ have added XGI already, by that metric.

This license is just stock 3-clause BSD, which had better be acceptable because
we're definitely shipping code covered by it.

Moving back to ASSIGNED, these aren't the droids you're looking for.

Created attachment 7936 [details]
Updates source code and add license header

(1). Add features such as LCD, DVI, TV , dual diplay, video, ...
(2). Add license header

Created attachment 7937 [details]
Updates source code and add license header

(1). Add features such as LCD, DVI, TV , dual display, video, ...
(2). Add license header

Created attachment 7938 [details]
Non-3D programming guide

Created attachment 7939 [details]
Data sheet of XGI 8300

Created attachment 8355 [details]
modularized source code

Modularlized version of the code drop.	I've fixed up the code drop and got it
building in the modular tree, however, at runtime the driver seems to have some
unresolved symbol issues that I haven't tracked down yet.  I'm not sure what
the magellan_*.c/.h files were for; they didn't appear to be used by anything
so I removed them.

I haven't been able to find an 8300/XP10, so I've been playing around with an
XP5/V3, which I hope is similar enough for at least basic mode setting to work.

Created attachment 8394 [details]
Modularlized source code

Updated modularlized source:

- Cleaned up the man page
- Fixed unresolved symbol issues; driver loads now

Not tested on any XP10 hardware yet.  I tried loading it on an XP5/V3 card, but
the bios calls seem to have some issues.

I've started a git tree for the driver here:
http://gitweb.freedesktop.org/?p=users/agd5f/xf86-video-xgixp.git;a=summary

Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.

Created attachment 10246 [details]
kernel device driver for xp10

kernel device driver for xp10.
it is need for xp10 X windows driver.

Can't you submit the kernel sources to the kernel community directly?

(In reply to comment #17)
> Not tested on any XP10 hardware yet.  I tried loading it on an XP5/V3 card,
> but the bios calls seem to have some issues.

XP5/V3 is still a trident based card (1023:2200). I'm not sure if it is comparable to a XP10. BTW, the trident driver doesn't work either for this
card.

[...]
(==) TRIDENT(0): Backing store disabled
(==) TRIDENT(0): Silken mouse enabled
(**) Option "dpms"
(**) TRIDENT(0): DPMS enabled

==> monitor turns off; Xserver load about 99%

(In reply to comment #22)
> BTW, the trident driver doesn't work either for this card.
> 
> [...]
> (==) TRIDENT(0): Backing store disabled
> (==) TRIDENT(0): Silken mouse enabled
> (**) Option "dpms"
> (**) TRIDENT(0): DPMS enabled
> 
> ==> monitor turns off; Xserver load about 99%

0xb711b536 in mmioReadST01 () from /usr/lib/xorg/modules//libvgahw.so
(gdb) bt
#0  0xb711b536 in mmioReadST01 () from /usr/lib/xorg/modules//libvgahw.so
#1  0xb714a6ca in TRIDENTResetVideo ()
   from /usr/lib/xorg/modules//drivers/trident_drv.so
#2  0xb714beda in TRIDENTInitVideo ()
   from /usr/lib/xorg/modules//drivers/trident_drv.so
#3  0xb7143ed0 in TRIDENTScreenInit ()
   from /usr/lib/xorg/modules//drivers/trident_drv.so
#4  0x0807375c in AddScreen ()
#5  0x080a744e in InitOutput ()
#6  0x08073ee6 in main ()
(gdb) 

Mass closure: This bug has been untouched for more than six years, and is not
obviously still valid. Please reopen this bug or file a new report if you continue to experience issues with current releases.