| Summary: | Add support for 147e:2020 | ||
|---|---|---|---|
| Product: | libfprint | Reporter: | Vasily Khoruzhick <anarsoul> |
| Component: | libfprint | Assignee: | libfprint-bugs |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | bugzilla, i.gnatenko.brain |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
0001-configure.ac-use-AC_CONFIG_HEADERS.patch
0002-upeke2-add-147e-2020-IDs.patch |
||
|
Description
Vasily Khoruzhick
2013-01-13 13:58:53 UTC
Created attachment 72959 [details] [review] 0001-configure.ac-use-AC_CONFIG_HEADERS.patch Created attachment 72960 [details] [review] 0002-upeke2-add-147e-2020-IDs.patch Comment on attachment 72959 [details] [review] 0001-configure.ac-use-AC_CONFIG_HEADERS.patch Review of attachment 72959 [details] [review]: ----------------------------------------------------------------- Looks good. Comment on attachment 72960 [details] [review] 0002-upeke2-add-147e-2020-IDs.patch Review of attachment 72960 [details] [review]: ----------------------------------------------------------------- Looks good too. Do you have a git account yet? ::: libfprint/drivers/upeke2.c @@ +854,3 @@ > static int discover(struct libusb_device_descriptor *dsc, uint32_t *devtype) > { > /* Revision 2 is what we're interested in */ You can remove that comment I guess. (In reply to comment #4) > Comment on attachment 72960 [details] [review] [review] > 0002-upeke2-add-147e-2020-IDs.patch > > Review of attachment 72960 [details] [review] [review]: > ----------------------------------------------------------------- > > Looks good too. Do you have a git account yet? Nope, see https://bugs.freedesktop.org/show_bug.cgi?id=56860 > ::: libfprint/drivers/upeke2.c > @@ +854,3 @@ > > static int discover(struct libusb_device_descriptor *dsc, uint32_t *devtype) > > { > > /* Revision 2 is what we're interested in */ > > You can remove that comment I guess. Yep, code is self-descriptive. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.