| Summary: | Use a portable variable assignment construct in configure.ac | ||
|---|---|---|---|
| Product: | Spice | Reporter: | Jasper Lievisse Adriaanse <jasper> |
| Component: | spice-gtk | Assignee: | Spice Bug List <spice-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | OpenBSD | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Use portable constructs in configure script.
Use portable constructs in configure script. |
||
No need for braces, in general we only use them where it's needed. no worries, we seem to mix both usage ;) pushed: http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=8268b07430d1dc2f40aec6b9fe4d895854ab87ed Created attachment 73407 [details] [review] Use portable constructs in configure script. I've just updated the patch :) Thanks for committing though. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 73401 [details] Use portable constructs in configure script. While the following may be a valid construct in bash: SPICE_GTK_REQUIRES+=" gtk+-$GTK_API_VERSION >= $GTK_REQUIRED" It is not in every shell. Hence this usage in configure.ac throws warnings like this when run on systems where bash is not the default shell: ./configure[15815]: SPICE_GTK_REQUIRES+= gtk+-3.0 >= 2.91.3: not foun The attached patch rewrites these into portable constructs that work on all systems, regardless of the shell.