Bug 59675 - Use a portable variable assignment construct in configure.ac
Summary: Use a portable variable assignment construct in configure.ac
Status: RESOLVED FIXED
Alias: None
Product: Spice
Classification: Unclassified
Component: spice-gtk (show other bugs)
Version: unspecified
Hardware: Other OpenBSD
: medium normal
Assignee: Spice Bug List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-21 18:55 UTC by Jasper Lievisse Adriaanse
Modified: 2013-01-21 20:24 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Use portable constructs in configure script. (1.23 KB, text/plain)
2013-01-21 18:55 UTC, Jasper Lievisse Adriaanse 		Details
Use portable constructs in configure script. (1.22 KB, patch)
2013-01-21 20:23 UTC, Jasper Lievisse Adriaanse 		Details | Splinter Review
Show Obsolete (1) View All

Description Jasper Lievisse Adriaanse 2013-01-21 18:55:52 UTC 
Created attachment 73401 [details]
Use portable constructs in configure script.

While the following may be a valid construct in bash:

SPICE_GTK_REQUIRES+=" gtk+-$GTK_API_VERSION >= $GTK_REQUIRED"

It is not in every shell. Hence this usage in configure.ac throws warnings like this when run on systems where bash is not the default shell:

./configure[15815]: SPICE_GTK_REQUIRES+= gtk+-3.0 >= 2.91.3: not foun

The attached patch rewrites these into portable constructs that work on all systems, regardless of the shell.
Comment 1 Marc-Andre Lureau 2013-01-21 20:17:42 UTC 
No need for braces, in general we only use them where it's needed.
Comment 2 Marc-Andre Lureau 2013-01-21 20:21:54 UTC 
no worries, we seem to mix both usage ;) pushed:


http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=8268b07430d1dc2f40aec6b9fe4d895854ab87ed
Comment 3 Jasper Lievisse Adriaanse 2013-01-21 20:23:56 UTC 
Created attachment 73407 [details] [review]
Use portable constructs in configure script.
Comment 4 Jasper Lievisse Adriaanse 2013-01-21 20:24:26 UTC 
I've just updated the patch :) Thanks for committing though.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.