Summary: | piglit glsl-uniform-out-of-bounds-2 regression | ||
---|---|---|---|
Product: | Mesa | Reporter: | Vinson Lee <vlee> |
Component: | Mesa core | Assignee: | Ian Romanick <idr> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | idr |
Version: | git | Keywords: | regression |
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | fix |
Description
Vinson Lee
2013-01-22 01:41:58 UTC
I contributed this test about the same time Ian was doing the [0] change, so I suspect it was missed when he checked piglit. I'm happy to take a look at it. Created attachment 73482 [details] [review] fix I just sent a slightly different patch to the piglit mailing list. http://lists.freedesktop.org/archives/piglit/2013-January/004730.html Fixed by piglit commit: commit 1398638bf325e0aad5b7e7f88520bc959ee90002 Author: Ian Romanick <ian.d.romanick@intel.com> Date: Mon Jan 28 16:28:25 2013 -0800 Accept array uniform names with or without [0] from glGetActiveUniform This is required by OpenGL ES 3.0 and desktop OpenGL 4.2. Previous version were ambiguous. Signed-off-by: Ian Romanick <ian.d.romanick@intel.com> Cc: Frank Henigman <fjhenigman@google.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59688 Reviewed-by: Carl Worth <cworth@cworth.org> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.