Bug 59688 - piglit glsl-uniform-out-of-bounds-2 regression
Summary: piglit glsl-uniform-out-of-bounds-2 regression
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Ian Romanick
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2013-01-22 01:41 UTC by Vinson Lee
Modified: 2013-02-19 21:00 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
fix (1.07 KB, patch)
2013-01-22 21:53 UTC, fjhenigman
Details | Splinter Review

Description Vinson Lee 2013-01-22 01:41:58 UTC
mesa: 3a91e7955ace2885cfb23089852018a8037ca134 (master)

$ ./bin/glsl-uniform-out-of-bounds-2 -auto
active uniforms 2
trying bogus location -2
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=-2)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=-2)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=-2)
trying bogus location 0
Mesa: User error: GL_INVALID_OPERATION in glUniform(type mismatch)
Unexpected GL error: GL_NO_ERROR 0x0
(Error at piglit/tests/shaders/glsl-uniform-out-of-bounds-2.c:150)
Expected GL error: GL_INVALID_OPERATION 0x502
FAIL: wrote matrix to bogus location
Unexpected GL error: GL_NO_ERROR 0x0
(Error at piglit/tests/shaders/glsl-uniform-out-of-bounds-2.c:155)
Expected GL error: GL_INVALID_OPERATION 0x502
FAIL: read from bogus location
trying bogus location 65533
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=65533)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=65533)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=65533)
trying bogus location -3
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=-3)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=-3)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=-3)
trying bogus location 1
Mesa: User error: GL_INVALID_OPERATION in glUniform(type mismatch)
Unexpected GL error: GL_NO_ERROR 0x0
(Error at piglit/tests/shaders/glsl-uniform-out-of-bounds-2.c:150)
Expected GL error: GL_INVALID_OPERATION 0x502
FAIL: wrote matrix to bogus location
Unexpected GL error: GL_NO_ERROR 0x0
(Error at piglit/tests/shaders/glsl-uniform-out-of-bounds-2.c:155)
Expected GL error: GL_INVALID_OPERATION 0x502
FAIL: read from bogus location
trying bogus location 65534
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=65534)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=65534)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=65534)
trying bogus location -4
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=-4)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=-4)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=-4)
trying bogus location 2
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=2)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=2)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=2)
trying bogus location 65535
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=65535)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=65535)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=65535)
trying bogus location -5
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=-5)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=-5)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=-5)
trying bogus location 3
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=3)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=3)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=3)
trying bogus location 65536
Unexpected GL error: GL_NO_ERROR 0x0
(Error at piglit/tests/shaders/glsl-uniform-out-of-bounds-2.c:145)
Expected GL error: GL_INVALID_OPERATION 0x502
FAIL: wrote vector to bogus location
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(non-matrix uniform)
Unexpected GL error: GL_NO_ERROR 0x0
(Error at piglit/tests/shaders/glsl-uniform-out-of-bounds-2.c:155)
Expected GL error: GL_INVALID_OPERATION 0x502
FAIL: read from bogus location
trying bogus location -6
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=-6)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=-6)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=-6)
trying bogus location 4
Mesa: User error: GL_INVALID_OPERATION in glUniform(location=4)
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(location=4)
Mesa: User error: GL_INVALID_OPERATION in glGetUniform(location=4)
trying bogus location 65537
Unexpected GL error: GL_NO_ERROR 0x0
(Error at piglit/tests/shaders/glsl-uniform-out-of-bounds-2.c:145)
Expected GL error: GL_INVALID_OPERATION 0x502
FAIL: wrote vector to bogus location
Mesa: User error: GL_INVALID_OPERATION in glUniformMatrix(non-matrix uniform)
Unexpected GL error: GL_NO_ERROR 0x0
(Error at piglit/tests/shaders/glsl-uniform-out-of-bounds-2.c:155)
Expected GL error: GL_INVALID_OPERATION 0x502
FAIL: read from bogus location
PIGLIT: {'result': 'fail' }


8ef3c83ffe538d09380baaac5c3cd86a9f97ca47 is the first bad commit
commit 8ef3c83ffe538d09380baaac5c3cd86a9f97ca47
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Fri Dec 14 15:01:48 2012 -0800

    mesa: Array uniform names are supposed to have [0] appended
    
    This is required by OpenGL ES 3.0 and desktop OpenGL 4.2.  Previous
    version were ambiguous.  This also matches the behavior of NVIDIA's
    closed-source driver (version 304.64).
    
    Fixed gles3conformance test uniform_buffer_object_getactiveuniform.
    
    Several piglit tests expect glGetActiveUniform to *not* include the [0]
    on the end.  These tests were already failing on NVIDIA, and this change
    regresses them on Mesa.  Patches have been sent to the piglit mailing
    list to fix the tests.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

:040000 040000 4adc878d5fbe89b7eb863c23a6d33983b9474833 cae46d8af723e33e763cf27e2153682822e9329a M	src
bisect run success
Comment 1 fjhenigman 2013-01-22 16:09:10 UTC
I contributed this test about the same time Ian was doing the [0] change, so I suspect it was missed when he checked piglit.  I'm happy to take a look at it.
Comment 2 fjhenigman 2013-01-22 21:53:05 UTC
Created attachment 73482 [details] [review]
fix
Comment 3 Ian Romanick 2013-01-29 00:31:00 UTC
I just sent a slightly different patch to the piglit mailing list.

http://lists.freedesktop.org/archives/piglit/2013-January/004730.html
Comment 4 Ian Romanick 2013-02-19 21:00:55 UTC
Fixed by piglit commit:

commit 1398638bf325e0aad5b7e7f88520bc959ee90002
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Mon Jan 28 16:28:25 2013 -0800

    Accept array uniform names with or without [0] from glGetActiveUniform
    
    This is required by OpenGL ES 3.0 and desktop OpenGL 4.2.  Previous
    version were ambiguous.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Cc: Frank Henigman <fjhenigman@google.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59688
    Reviewed-by: Carl Worth <cworth@cworth.org>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.