Bug 59690

Summary: [GM45/ILK Bisected]Piglit spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_single_sampled_disabled fails
Product: Mesa Reporter: lu hua <huax.lu>
Component: Drivers/DRI/i965Assignee: Ian Romanick <idr>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: jljusten, mattst88, xunx.fang
Version: unspecified   
Hardware: All   
OS: Linux (All)   
See Also: https://bugs.freedesktop.org/show_bug.cgi?id=60073
Whiteboard:
i915 platform: i915 features:

Description lu hua 2013-01-22 01:52:24 UTC 
System Environment:
--------------------------
Arch:           x86_64
Platform:       Ironlake
Libdrm:		(master)libdrm-2.4.41-3-g303ca37e722e68900cb7eb43ddbef8069b0c711b
Mesa:	(master)a076c272e29bdb6dd32f7f7cabbc735d619f89b4
Xserver:(master)xorg-server-1.13.99.901-34-g069d8ed3eb659c48dd2b0f8b7b8c11f092fdb362
Xf86_video_intel:(master)2.20.19-9-g208ca91a31182e8ddad36e6a735c725362cbd071
Cairo:		(master)ed2fa6b16b03fccc3e21598cdb9157cbcebd1d37
Libva:		(staging)21649988d6b532cc96f633db017d1e4369f640e9
Libva_intel_driver:(staging)d206b47a6ac86c089149ecd71b01eea6ebda5796
Kernel:	(drm-intel-nightly) f70dd67f27b82e3e1a0c508e3fd7ec5c4b670a41

Bug detailed description:
-------------------------
It happens on ironlake and GM45 with mesa master branch. It works well on mesa 9.0 branch.

Following cases also fail and have same bisect info.
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_single_sampled_enabled
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_to_linear_single_sampled_disabled
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_to_linear_single_sampled_enabled
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_to_linear_upsample_disabled
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_to_linear_upsample_enabled
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_upsample_disabled
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_upsample_enabled

Bisect shows: 3b51d71c8544ee198008bbf3545bf3def6e9e77f is the first bad commit.
commit 3b51d71c8544ee198008bbf3545bf3def6e9e77f
Author:     Jordan Justen <jordan.l.justen@intel.com>
AuthorDate: Fri Dec 28 11:00:50 2012 -0800
Commit:     Matt Turner <mattst88@gmail.com>
CommitDate: Sun Jan 20 19:54:38 2013 -0800

    copyteximage: check that sRGB usage is valid for GLES3 / GL

output:
Probe at (0,0)
  Expected: 0.000000 0.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000 1.000000
PIGLIT: {'result': 'fail' }

Reproduce steps:
----------------
1. xinit
2. ./bin/arb_framebuffer_srgb-blit renderbuffer srgb single_sampled disabled -auto -fbo
Comment 1 Ian Romanick 2013-01-29 19:54:53 UTC 
I suspect this bug only occurs on ILK and earlier because those chips don't use blorp (they use meta).  If that is the case, then this is a pre-existing issue in the meta code.
Comment 2 Alex Deucher 2013-01-30 13:57:02 UTC 
Seems to cause a regression is r600g as well.  See bug 60073.
Comment 3 Jordan Justen 2013-02-12 22:02:36 UTC 
Does 496928a4 fix this?
Comment 4 Eric Anholt 2013-02-21 00:51:05 UTC 
Yeah, the test passes here now on GM45.
Comment 5 fangxun 2013-02-21 03:12:44 UTC 
Verified. Note following cases are skiped on ILK and gm45 on mesa master now.
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_to_linear_upsample_disabled
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_to_linear_upsample_enabled
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_upsample_disabled
spec_ARB_framebuffer_sRGB_blit_renderbuffer_srgb_upsample_enabled

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.