| Summary: | [swrast] piglit glx-swap-pixmap regression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | Ian Romanick <idr> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | cworth |
| Version: | git | Keywords: | regression |
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
It looks like another test bug. I just sent a patch to the piglit list. Can you verify that it fixes the problem on your end? http://lists.freedesktop.org/archives/piglit/2013-January/004732.html Fixed by piglit commit: commit 39ef626e49246d1ce43ce12ccb13f81faeba604a Author: Ian Romanick <ian.d.romanick@intel.com> Date: Mon Jan 28 16:38:44 2013 -0800 glx-swap-pixmap: Expect alpha = 1.0 if there is no alpha in the pixmap Signed-off-by: Ian Romanick <ian.d.romanick@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59833 Reviewed-by: Carl Worth <cworth@cworth.org> Reviewed-by: Brian Paul <brianp@vmware.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
mesa: d1f2e9699f3e5e7649fc12c4f2409af91d2494fe (master) $ ./bin/glx-swap-pixmap -auto Probe at (0,0) Expected: 0.000000 1.000000 0.000000 0.000000 Observed: 0.000000 1.000000 0.000000 1.000000 PIGLIT: {'result': 'fail' } 570ed2be7d776211e1ca2a7a4c44ee6a1d141714 is the first bad commit commit 570ed2be7d776211e1ca2a7a4c44ee6a1d141714 Author: Carl Worth <cworth@cworth.org> Date: Mon Jan 21 12:16:27 2013 -0800 ReadPixels: Force ALPHA to 1 while rebasing RGBA values for GL_RGB format When performing a ReadPixels operation, we may be reading from a buffer that stores alpha values, but that is actually representing a buffer with no alpha channel. In this case, while rebasing the values, touch up all alpha values read to 1.0. This commit fixes the following piglit (sub) tests: ARB_texture_float/fbo-colormask-formats GL_RBG16F_ARB EXT_texture_snorm/fbo-colormask-formats GL_RGB16_SNORM GL_RGB8_SNORM GL_RGB_SNORM It likely improves the results of other tests as well, but a PASS remains elusive due to additional bugs. Reviewed-by: Brian Paul <brianp@vmware.com> Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com> :040000 040000 144369a7d3779929bad84beca8f3a5b2ccf90640 c25eb37e73f6f6e5435230fe8a799b1b62ed347b M src bisect run success