Bug 59833 - [swrast] piglit glx-swap-pixmap regression
Summary: [swrast] piglit glx-swap-pixmap regression
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Ian Romanick
QA Contact:
Keywords: regression
Depends on:
Reported: 2013-01-25 05:14 UTC by Vinson Lee
Modified: 2013-01-29 19:49 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Description Vinson Lee 2013-01-25 05:14:31 UTC
mesa: d1f2e9699f3e5e7649fc12c4f2409af91d2494fe (master)

$ ./bin/glx-swap-pixmap -auto
Probe at (0,0)
  Expected: 0.000000 1.000000 0.000000 0.000000
  Observed: 0.000000 1.000000 0.000000 1.000000
PIGLIT: {'result': 'fail' }

570ed2be7d776211e1ca2a7a4c44ee6a1d141714 is the first bad commit
commit 570ed2be7d776211e1ca2a7a4c44ee6a1d141714
Author: Carl Worth <cworth@cworth.org>
Date:   Mon Jan 21 12:16:27 2013 -0800

    ReadPixels: Force ALPHA to 1 while rebasing RGBA values for GL_RGB format
    When performing a ReadPixels operation, we may be reading from a buffer that
    stores alpha values, but that is actually representing a buffer with no alpha
    channel. In this case, while rebasing the values, touch up all alpha values
    read to 1.0.
    This commit fixes the following piglit (sub) tests:
    It likely improves the results of other tests as well, but a PASS remains
    elusive due to additional bugs.
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>

:040000 040000 144369a7d3779929bad84beca8f3a5b2ccf90640 c25eb37e73f6f6e5435230fe8a799b1b62ed347b M	src
bisect run success
Comment 1 Ian Romanick 2013-01-29 00:40:34 UTC
It looks like another test bug.  I just sent a patch to the piglit list.  Can you verify that it fixes the problem on your end?

Comment 2 Ian Romanick 2013-01-29 19:49:17 UTC
Fixed by piglit commit:

commit 39ef626e49246d1ce43ce12ccb13f81faeba604a
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Mon Jan 28 16:38:44 2013 -0800

    glx-swap-pixmap: Expect alpha = 1.0 if there is no alpha in the pixmap
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59833
    Reviewed-by: Carl Worth <cworth@cworth.org>
    Reviewed-by: Brian Paul <brianp@vmware.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.