Summary: | AC_ARG_WITH misusage leading to mesa configure failure | ||
---|---|---|---|
Product: | Mesa | Reporter: | Quentin "Sardem FF7" Glidic <sardemff7+freedesktop> |
Component: | Mesa core | Assignee: | mesa-dev |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | lonewolf, tstellar |
Version: | git | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
Patch to fix mesa configure
Patch to fix mesa configure |
*** Bug 59994 has been marked as a duplicate of this bug. *** Created attachment 73992 [details] [review] Patch to fix mesa configure Patch fixed and with a different logic. Now force-enable LLVM shared libraries in a post-check, with a warning for the user. (In reply to comment #2) > Created attachment 73992 [details] [review] [review] > Patch to fix mesa configure > > Patch fixed and with a different logic. Now force-enable LLVM shared > libraries in a post-check, with a warning for the user. Thanks for the patch, it looks good to me, but I need to test it out on a few configurations before I push it. Fixed by commit 1e857130f06d7db0c77d73b6356528f4792967ff Thanks for the patch! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 73648 [details] Patch to fix mesa configure Copy of the commit message: The third argument of AC_ARG_WITH is evaluated for any provided value, not only on --with-, so it must not force-enable the feature Also, setting $with_llvm_shared_libs in the opencl check was overriding the user switch