| Summary: | GL headers being used in DDX drivers | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Jeremy C. Reed <reed> |
| Component: | Server/Ext/GLX | Assignee: | Xorg Project Team <xorg-team> |
| Status: | RESOLVED WORKSFORME | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | high | CC: | jeremyhu |
| Version: | git | ||
| Hardware: | x86 (IA32) | ||
| OS: | other | ||
| Whiteboard: | 2011BRB_Reviewed | ||
| i915 platform: | i915 features: | ||
Seeing as GL/gl.h gets included by GL/glxint.h, not the driver, shouldn't this be handled by proto/GL? more accurately, none of the DDX drivers should ever need to pull in GL types or functions anyway. (In reply to comment #2) > more accurately, none of the DDX drivers should ever need to pull in GL types or > functions anyway. the dependency in question: In file included from ../../src/glint.h:44, from ../../src/glint_dga.c:36: ../../src/glint_dripriv.h:38: error: expected declaration specifiers or '...' before '__GLXvisualConfig' In file included from ../../src/glint_dga.c:36: ../../src/glint.h:180: error: expected specifier-qualifier-list before '__GLXvisualConfig' not really sure how best to resolve this. moving to the doc tracker, not going to fix this directly for 7.1 at this point, but it at least needs to be noted. Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future. Ping. Removed from doc tracker. It's been noted for years. Can we fix this now? It's been a while and glproto has changed a bit. Is this still an issue? If so, what's blocking the fix? No response. Closing assumed fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Please have configure check for GL before attempting build: driver/xf86-video-ati/configure.ac driver/xf86-video-glint/configure.ac driver/xf86-video-i810/configure.ac driver/xf86-video-mga/configure.ac driver/xf86-video-savage/configure.ac driver/xf86-video-sis/configure.ac driver/xf86-video-tdfx/configure.ac driver/xf86-video-via/configure.ac Or you will get later errors like: In file included from glint.h:44, from glint_dga.c:37: /home/reed/xorg/include/GL/glxint.h:28:19: GL/gl.h: No such file or directory In file included from glint.h:44, from glint_dga.c:37: /home/reed/xorg/include/GL/glxint.h:95: error: syntax error before "GLboolean" (My workaround for now is that I actually have a pkgconfig file gl.pc and added "gl" to the PKG_CHECK_MODULES.)