Bug 6193 - GL headers being used in DDX drivers
Summary: GL headers being used in DDX drivers
Status: RESOLVED WORKSFORME
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Ext/GLX (show other bugs)
Version: git
Hardware: x86 (IA32) other
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard: 2011BRB_Reviewed
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-09 18:09 UTC by Jeremy C. Reed
Modified: 2011-10-15 18:50 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Jeremy C. Reed 2006-03-09 18:09:40 UTC 
Please have configure check for GL before attempting build:

driver/xf86-video-ati/configure.ac
driver/xf86-video-glint/configure.ac
driver/xf86-video-i810/configure.ac
driver/xf86-video-mga/configure.ac
driver/xf86-video-savage/configure.ac
driver/xf86-video-sis/configure.ac
driver/xf86-video-tdfx/configure.ac
driver/xf86-video-via/configure.ac

Or you will get later errors like:
In file included from glint.h:44,
                 from glint_dga.c:37:
/home/reed/xorg/include/GL/glxint.h:28:19: GL/gl.h: No such file or directory
In file included from glint.h:44,
                 from glint_dga.c:37:
/home/reed/xorg/include/GL/glxint.h:95: error: syntax error before "GLboolean"

(My workaround for now is that I actually have a pkgconfig file gl.pc and added
"gl" to the PKG_CHECK_MODULES.)
Comment 1 Michel Dänzer 2006-03-09 20:35:48 UTC 
Seeing as GL/gl.h gets included by GL/glxint.h, not the driver, shouldn't this
be handled by proto/GL?
Comment 2 Adam Jackson 2006-03-12 08:25:08 UTC 
more accurately, none of the DDX drivers should ever need to pull in GL types or
functions anyway.
Comment 3 Adam Jackson 2006-04-13 06:36:05 UTC 
(In reply to comment #2)
> more accurately, none of the DDX drivers should ever need to pull in GL types or
> functions anyway.

the dependency in question:

In file included from ../../src/glint.h:44,
                 from ../../src/glint_dga.c:36:
../../src/glint_dripriv.h:38: error: expected declaration specifiers or '...'
before '__GLXvisualConfig'
In file included from ../../src/glint_dga.c:36:
../../src/glint.h:180: error: expected specifier-qualifier-list before
'__GLXvisualConfig'

not really sure how best to resolve this.
Comment 4 Adam Jackson 2006-05-19 03:22:51 UTC 
moving to the doc tracker, not going to fix this directly for 7.1 at this point,
but it at least needs to be noted.
Comment 5 Daniel Stone 2007-02-27 01:30:48 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 6 Matt Turner 2010-02-15 18:47:01 UTC 
Ping.
Comment 7 Jeremy Huddleston Sequoia 2011-10-03 17:42:39 UTC 
Removed from doc tracker.  It's been noted for years.

Can we fix this now?  It's been a while and glproto has changed a bit.  Is this still an issue?  If so, what's blocking the fix?
Comment 8 Jeremy Huddleston Sequoia 2011-10-15 18:50:35 UTC 
No response.  Closing assumed fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.