Bug 62162

Summary:	Support for floating point settings
Product:	realmd	Reporter:	Marius Vollmer <marius.vollmer>
Component:	General	Assignee:	Stef Walter <stefw>
Status:	VERIFIED FIXED	QA Contact:
Severity:	enhancement
Priority:	medium	CC:	stefw
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	62212
Attachments:	Adds realm_settings_double function. Adds realm_settings_double function.

Description Marius Vollmer 2013-03-11 11:20:33 UTC

Created attachment 76330 [details] [review]
Adds realm_settings_double function.

This is needed by upcoming example provider features.

Comment 1 Marius Vollmer 2013-03-11 11:24:38 UTC

Created attachment 76331 [details] [review]
Adds realm_settings_double function.

Correct whitespacing.

Comment 2 Stef Walter 2013-03-22 12:54:14 UTC

Comment on attachment 76331 [details] [review]
Adds realm_settings_double function.

Review of attachment 76331 [details] [review]:
-----------------------------------------------------------------

Added line to .gitignore

::: service/realm-settings.c
@@ +196,5 @@
> +		return def;
> +
> +	val = g_ascii_strtod (string, &end_ptr);
> +	if (*end_ptr != '\0') {
> +		g_critical ("Can't parse '%s' as a floating point number", string);

Added a clearer message.

::: tests/test-settings.c
@@ +8,5 @@
> + * your option) any later version.
> + *
> + * See the included COPYING file for more information.
> + *
> + * Author: Stef Walter <stefw@gnome.org>

I've put your name/email here.

Comment 3 Stef Walter 2013-03-22 12:55:27 UTC

Thanks for doing the tests.

Comment 4 Marius Vollmer 2013-04-15 11:31:01 UTC

Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.