Bug 62162 - Support for floating point settings
Summary: Support for floating point settings
Status: VERIFIED FIXED
Alias: None
Product: realmd
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Stef Walter
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 62212
  Show dependency treegraph
 
Reported: 2013-03-11 11:20 UTC by Marius Vollmer
Modified: 2013-04-15 11:31 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Adds realm_settings_double function. (6.67 KB, patch)
2013-03-11 11:20 UTC, Marius Vollmer
Details | Splinter Review
Adds realm_settings_double function. (6.78 KB, patch)
2013-03-11 11:24 UTC, Marius Vollmer
Details | Splinter Review

Description Marius Vollmer 2013-03-11 11:20:33 UTC
Created attachment 76330 [details] [review]
Adds realm_settings_double function.

This is needed by upcoming example provider features.
Comment 1 Marius Vollmer 2013-03-11 11:24:38 UTC
Created attachment 76331 [details] [review]
Adds realm_settings_double function.

Correct whitespacing.
Comment 2 Stef Walter 2013-03-22 12:54:14 UTC
Comment on attachment 76331 [details] [review]
Adds realm_settings_double function.

Review of attachment 76331 [details] [review]:
-----------------------------------------------------------------

Added line to .gitignore

::: service/realm-settings.c
@@ +196,5 @@
> +		return def;
> +
> +	val = g_ascii_strtod (string, &end_ptr);
> +	if (*end_ptr != '\0') {
> +		g_critical ("Can't parse '%s' as a floating point number", string);

Added a clearer message.

::: tests/test-settings.c
@@ +8,5 @@
> + * your option) any later version.
> + *
> + * See the included COPYING file for more information.
> + *
> + * Author: Stef Walter <stefw@gnome.org>

I've put your name/email here.
Comment 3 Stef Walter 2013-03-22 12:55:27 UTC
Thanks for doing the tests.
Comment 4 Marius Vollmer 2013-04-15 11:31:01 UTC
Thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.