| Summary: | RFE: Automatically disable compression for local-only | ||
|---|---|---|---|
| Product: | Spice | Reporter: | Zeeshan Ali <zeenix> |
| Component: | server | Assignee: | Spice Bug List <spice-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Zeeshan Ali
2013-03-11 18:49:48 UTC
ping? there is already some code to adjust compression settings depending on bandwidth. For local case only, we should be able to figure out if the socket is unix (does Boxes use that these days?), and disable compression completely then. I think this might doable relatively easily, but the benefit is still marginal since most adjustements are already made. (In reply to Marc-Andre Lureau from comment #2) > there is already some code to adjust compression settings depending on > bandwidth. > > For local case only, we should be able to figure out if the socket is unix > (does Boxes use that these days?), and disable compression completely then. > I think this might doable relatively easily, but the benefit is still > marginal since most adjustements are already made. Cool. Boxes doesn't yet use unix socket but I was hoping I fix that before 3.16. I am not entirely sure I understand yet how to achieve that but I hope to learn from the pointers provided by teuf and danpb: https://bugzilla.gnome.org/show_bug.cgi?id=738573 (In reply to Zeeshan Ali from comment #3) > (In reply to Marc-Andre Lureau from comment #2) > > there is already some code to adjust compression settings depending on > > bandwidth. > > > > For local case only, we should be able to figure out if the socket is unix > > (does Boxes use that these days?), and disable compression completely then. > > I think this might doable relatively easily, but the benefit is still > > marginal since most adjustements are already made. > > Cool. Boxes doesn't yet use unix socket but I was hoping I fix that before > 3.16. I am not entirely sure I understand yet how to achieve that but I hope > to learn from the pointers provided by teuf and danpb: > > https://bugzilla.gnome.org/show_bug.cgi?id=738573 OK, that is done now (at least on Boxes side). Does spice already disables compression when connected through unix socket? (In reply to Zeeshan Ali from comment #4) > OK, that is done now (at least on Boxes side). Does spice already disables > compression when connected through unix socket? there are already heuristics to tune compression depending on bandwidth. recently, I added some more code to disable some unnecessary steps when using unix socket: http://cgit.freedesktop.org/spice/spice/commit/?id=72cc0cff710f8be3e721fed82ab2ce519f03ccb4 Imho, there are still things possible left, but this is quite clearly low priority. (In reply to Marc-Andre Lureau from comment #5) > (In reply to Zeeshan Ali from comment #4) > > OK, that is done now (at least on Boxes side). Does spice already disables > > compression when connected through unix socket? > > there are already heuristics to tune compression depending on bandwidth. > > recently, I added some more code to disable some unnecessary steps when > using unix socket: > http://cgit.freedesktop.org/spice/spice/commit/ > ?id=72cc0cff710f8be3e721fed82ab2ce519f03ccb4 > > Imho, there are still things possible left, but this is quite clearly low > priority. Cool. Please feel free to close this bug then. AFAIK "WORKSFORME" means "the bug might be valid but I just can't reproduce it" so not the right resolution IMHO but up to you.. more heuristic recently http://cgit.freedesktop.org/spice/spice/commit/?id=6b4c036bdba53ddafde0a706c6de5d2172c09b25 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.