Bug 62968

Summary: [PATCH] telepathy-example-contact-list iteration through account bug
Product: Telepathy Reporter: Maksim Melnikau <maxposedon>
Component: tp-glibAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: minor    
Priority: medium    
Version: git master   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: contact-list-C-example-fix-iterating.patch

Description Maksim Melnikau 2013-03-31 17:16:49 UTC
Created attachment 77256 [details] [review]
contact-list-C-example-fix-iterating.patch

telepathy-exampple-contact-list don't interate through contacts, and it shows n-times first account (from n others)
Comment 1 Simon McVittie 2013-04-02 09:08:04 UTC
Comment on attachment 77256 [details] [review]
contact-list-C-example-fix-iterating.patch

Review of attachment 77256 [details] [review]:
-----------------------------------------------------------------

::: examples/client/contact-list.c
@@ +31,4 @@
>    accounts = tp_account_manager_dup_valid_accounts (manager);
>    for (l = accounts; l != NULL; l = l->next)
>      {
> +      TpAccount *account = l->data;

Thanks, well caught. I'll apply this in a moment.
Comment 2 Simon McVittie 2013-04-02 13:41:15 UTC
Fixed in git for 0.20.2 and 0.21.0, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.