Bug 62968 - [PATCH] telepathy-example-contact-list iteration through account bug
Summary: [PATCH] telepathy-example-contact-list iteration through account bug
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium minor
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-31 17:16 UTC by Maksim Melnikau
Modified: 2013-06-20 14:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
contact-list-C-example-fix-iterating.patch (925 bytes, patch)
2013-03-31 17:16 UTC, Maksim Melnikau 		Details | Splinter Review
View All

Description Maksim Melnikau 2013-03-31 17:16:49 UTC 
Created attachment 77256 [details] [review]
contact-list-C-example-fix-iterating.patch

telepathy-exampple-contact-list don't interate through contacts, and it shows n-times first account (from n others)
Comment 1 Simon McVittie 2013-04-02 09:08:04 UTC 
Comment on attachment 77256 [details] [review]
contact-list-C-example-fix-iterating.patch

Review of attachment 77256 [details] [review]:
-----------------------------------------------------------------

::: examples/client/contact-list.c
@@ +31,4 @@
>    accounts = tp_account_manager_dup_valid_accounts (manager);
>    for (l = accounts; l != NULL; l = l->next)
>      {
> +      TpAccount *account = l->data;

Thanks, well caught. I'll apply this in a moment.
Comment 2 Simon McVittie 2013-04-02 13:41:15 UTC 
Fixed in git for 0.20.2 and 0.21.0, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.