Bug 63440

Summary:	[PATCH] configure: Specify GLib min/max version
Product:	PolicyKit	Reporter:	Colin Walters <walters>
Component:	daemon	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:	David Zeuthen (not reading bugmail) <zeuthen>
Severity:	normal
Priority:	medium	CC:	walters
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	0001-configure-Specify-GLib-min-max-version.patch 0001-configure-Specify-GLib-min-max-version.patch Tested patch

Description Colin Walters 2013-04-11 18:38:11 UTC

Mainly to avoid deprecation warnings about g_type_init().
---
 configure.ac |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comment 1 Colin Walters 2013-04-11 18:38:45 UTC

Created attachment 77826 [details] [review]
0001-configure-Specify-GLib-min-max-version.patch

Comment 2 Miloslav Trmac 2013-04-12 16:10:10 UTC

I'd prefer (untested!)

AC_DEFINE([GLIB_VERSION_MIN_REQUIRED], [GLIB_VERSION_2_30],
	[Avoid warning spew about g_type_init() being deprecated])
AC_DEFINE([GLIB_VERSION_MAX_ALLOWED] [G_ENCODE_VERSION(2,34)],
        [Notify us when we'll need to transition away from g_type_init()])

or something like that; this will put the definition in <config.h> instead of every line of the detailed build log.

Comment 3 Colin Walters 2013-04-12 16:17:32 UTC

Created attachment 77893 [details] [review]
0001-configure-Specify-GLib-min-max-version.patch

Now using AC_DEFINE.

Note to make this work we need to #include "config.h" first thing.

Comment 4 Miloslav Trmac 2013-04-12 18:00:35 UTC

Created attachment 77906 [details] [review]
Tested patch

Comment 5 Miloslav Trmac 2013-04-12 18:01:23 UTC

(In reply to comment #3)
> Created attachment 77893 [details] [review] [review]
> 0001-configure-Specify-GLib-min-max-version.patch
> 
> Now using AC_DEFINE.
> 
> Note to make this work we need to #include "config.h" first thing.

ACK, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.