Bug 63440 - [PATCH] configure: Specify GLib min/max version
Summary: [PATCH] configure: Specify GLib min/max version
Status: RESOLVED FIXED
Alias: None
Product: PolicyKit
Classification: Unclassified
Component: daemon (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact: David Zeuthen (not reading bugmail)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-11 18:38 UTC by Colin Walters
Modified: 2013-04-12 22:23 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
0001-configure-Specify-GLib-min-max-version.patch (865 bytes, patch)
2013-04-11 18:38 UTC, Colin Walters 		Details | Splinter Review
0001-configure-Specify-GLib-min-max-version.patch (1.76 KB, patch)
2013-04-12 16:17 UTC, Colin Walters 		Details | Splinter Review
Tested patch (944 bytes, patch)
2013-04-12 18:00 UTC, Miloslav Trmac 		Details | Splinter Review
Show Obsolete (1) View All

Description Colin Walters 2013-04-11 18:38:11 UTC 
Mainly to avoid deprecation warnings about g_type_init().
---
 configure.ac |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Comment 1 Colin Walters 2013-04-11 18:38:45 UTC 
Created attachment 77826 [details] [review]
0001-configure-Specify-GLib-min-max-version.patch
Comment 2 Miloslav Trmac 2013-04-12 16:10:10 UTC 
I'd prefer (untested!)

AC_DEFINE([GLIB_VERSION_MIN_REQUIRED], [GLIB_VERSION_2_30],
	[Avoid warning spew about g_type_init() being deprecated])
AC_DEFINE([GLIB_VERSION_MAX_ALLOWED] [G_ENCODE_VERSION(2,34)],
        [Notify us when we'll need to transition away from g_type_init()])

or something like that; this will put the definition in <config.h> instead of every line of the detailed build log.
Comment 3 Colin Walters 2013-04-12 16:17:32 UTC 
Created attachment 77893 [details] [review]
0001-configure-Specify-GLib-min-max-version.patch

Now using AC_DEFINE.

Note to make this work we need to #include "config.h" first thing.
Comment 4 Miloslav Trmac 2013-04-12 18:00:35 UTC 
Created attachment 77906 [details] [review]
Tested patch
Comment 5 Miloslav Trmac 2013-04-12 18:01:23 UTC 
(In reply to comment #3)
> Created attachment 77893 [details] [review] [review]
> 0001-configure-Specify-GLib-min-max-version.patch
> 
> Now using AC_DEFINE.
> 
> Note to make this work we need to #include "config.h" first thing.

ACK, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.