| Summary: | [Patch] Fix build with srcdir != builddir | ||
|---|---|---|---|
| Product: | PolicyKit | Reporter: | Miloslav Trmac <mitr> |
| Component: | daemon | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
| Status: | RESOLVED FIXED | QA Contact: | David Zeuthen (not reading bugmail) <zeuthen> |
| Severity: | normal | ||
| Priority: | medium | CC: | walters |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
0001-Clean-git-status-after-autogen.sh.patch
0002-Fix-build-with-srcdir-builddir.patch 0003-Fix-DOC_SOURCE_DIR-for-builddir-srcdir.patch |
||
|
Description
Miloslav Trmac
2013-04-12 16:37:04 UTC
Created attachment 77897 [details] [review] 0002-Fix-build-with-srcdir-builddir.patch Created attachment 77898 [details] [review] 0003-Fix-DOC_SOURCE_DIR-for-builddir-srcdir.patch Note to self: this is my clean-git branch; after applying I should send dependent branches gtkdoc-cleanups and no-warnings Comment on attachment 77896 [details] [review] 0001-Clean-git-status-after-autogen.sh.patch Review of attachment 77896 [details] [review]: ----------------------------------------------------------------- Personally I build with srcdir != builddir so I don't see much of this myself, but this looks fine to me. Comment on attachment 77897 [details] [review] 0002-Fix-build-with-srcdir-builddir.patch Review of attachment 77897 [details] [review]: ----------------------------------------------------------------- Ah, yeah gtk-doc has traditionally been fairly bad with srcdir != builddir but I thought most of that was fixed now. Looks fine if it works for you. Comment on attachment 77898 [details] [review] 0003-Fix-DOC_SOURCE_DIR-for-builddir-srcdir.patch Review of attachment 77898 [details] [review]: ----------------------------------------------------------------- Looks fine, yep. Pushed all of these to git master. Thanks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.