Bug 63479 - [Patch] Fix build with srcdir != builddir
Summary: [Patch] Fix build with srcdir != builddir
Status: RESOLVED FIXED
Alias: None
Product: PolicyKit
Classification: Unclassified
Component: daemon (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact: David Zeuthen (not reading bugmail)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-12 16:37 UTC by Miloslav Trmac
Modified: 2013-04-15 21:12 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
0001-Clean-git-status-after-autogen.sh.patch (1.20 KB, patch)
2013-04-12 16:37 UTC, Miloslav Trmac 		Details | Splinter Review
0002-Fix-build-with-srcdir-builddir.patch (975 bytes, patch)
2013-04-12 16:37 UTC, Miloslav Trmac 		Details | Splinter Review
0003-Fix-DOC_SOURCE_DIR-for-builddir-srcdir.patch (1.15 KB, patch)
2013-04-12 16:38 UTC, Miloslav Trmac 		Details | Splinter Review
View All

Description Miloslav Trmac 2013-04-12 16:37:04 UTC 
Created attachment 77896 [details] [review]
0001-Clean-git-status-after-autogen.sh.patch

... and clean up to make (git status) usable without -uno .
Comment 1 Miloslav Trmac 2013-04-12 16:37:19 UTC 
Created attachment 77897 [details] [review]
0002-Fix-build-with-srcdir-builddir.patch
Comment 2 Miloslav Trmac 2013-04-12 16:38:22 UTC 
Created attachment 77898 [details] [review]
0003-Fix-DOC_SOURCE_DIR-for-builddir-srcdir.patch

Note to self: this is my clean-git branch; after applying I should send dependent branches gtkdoc-cleanups and no-warnings
Comment 3 Colin Walters 2013-04-12 16:40:28 UTC 
Comment on attachment 77896 [details] [review]
0001-Clean-git-status-after-autogen.sh.patch

Review of attachment 77896 [details] [review]:
-----------------------------------------------------------------

Personally I build with srcdir != builddir so I don't see much of this myself, but this looks fine to me.
Comment 4 Colin Walters 2013-04-12 16:41:20 UTC 
Comment on attachment 77897 [details] [review]
0002-Fix-build-with-srcdir-builddir.patch

Review of attachment 77897 [details] [review]:
-----------------------------------------------------------------

Ah, yeah gtk-doc has traditionally been fairly bad with srcdir != builddir but I thought most of that was fixed now.  Looks fine if it works for you.
Comment 5 Colin Walters 2013-04-12 16:42:01 UTC 
Comment on attachment 77898 [details] [review]
0003-Fix-DOC_SOURCE_DIR-for-builddir-srcdir.patch

Review of attachment 77898 [details] [review]:
-----------------------------------------------------------------

Looks fine, yep.
Comment 6 Colin Walters 2013-04-12 16:46:34 UTC 
Pushed all of these to git master.
Comment 7 Miloslav Trmac 2013-04-15 21:12:53 UTC 
Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.