Bug 63867

Ken, can you reproduce this?

Forcing tiling to I915_TILING_X instead of I915_TILING_X | I915_TILING_Y in
"i965/intel_mipmap_tree.c::intel_miptree_choose_tiling()" lets me to reproduce this on Sandybridge.
This may well go over my head but I'm looking into it as a learning exercise anyway. At least it gives me a reason to understand the X vs. Y-tiling algorithm in general.

(In reply to comment #2)
> Forcing tiling to I915_TILING_X instead of I915_TILING_X | I915_TILING_Y in
> "i965/intel_mipmap_tree.c::intel_miptree_choose_tiling()" lets me to
> reproduce this on Sandybridge.
> This may well go over my head but I'm looking into it as a learning exercise
> anyway. At least it gives me a reason to understand the X vs. Y-tiling
> algorithm in general.

Sorry about misleading, I meant to say that I can reproduce it with current mesa-master on Sandybridge and if I switch the tiling to X-only, the test passes.

I'll assign this for myself for now. I'm now studying the test case itself in order to understand the error better.

*** Bug 67857 has been marked as a duplicate of this bug. ***

Chad and Paul were talking about format restrictions related to Y-tiling the other day, and happened to stumble across the solution.  I've written a patch:

http://lists.freedesktop.org/archives/mesa-dev/2013-August/043267.html

(In reply to comment #6)
> Chad and Paul were talking about format restrictions related to Y-tiling the
> other day, and happened to stumble across the solution.  I've written a
> patch:
> 
> http://lists.freedesktop.org/archives/mesa-dev/2013-August/043267.html


Fixed by this patch except case "spec_glsl-1.30_execution_isinf-and-isnan_fs_fbo"
run: ./bin/isinf-and-isnan fs_fbo -auto
output:
 expression    expect isinf isnan sign  >0?      value        delta
           1000.0 finite false false    1  true         1000            0 OK
         1000.0+z finite false  true    1  true         1000            0 FAIL
          -1000.0 finite false false   -1 false        -1000            0 OK
        -1000.0+z finite false  true   -1  true        -1000            0 FAIL
            u_inf   +Inf false  true    1  true          inf         -nan FAIL
      exp(1000.0)   +Inf  true false    1  true          inf         -nan OK
    exp(1000.0+z)   +Inf false  true    1  true          inf         -nan FAIL
      u_minus_inf   -Inf false  true   -1  true         -inf         -nan FAIL
     -exp(1000.0)   -Inf  true false   -1 false         -inf         -nan OK
   -exp(1000.0+z)   -Inf false  true   -1  true         -inf         -nan FAIL
            u_nan    NaN false  true    0  true          nan         -nan OK
          0.0/0.0    NaN false  true    0 false         -nan         -nan OK
              z/z    NaN false  true    0  true         -nan         -nan OK
u_inf/u_minus_inf    NaN false  true    0  true         -nan         -nan OK
          z*u_inf    NaN false  true    0  true         -nan         -nan OK
u_inf+u_minus_inf    NaN false  true    0  true         -nan         -nan OK
        log(-1.0)    NaN false  true    0 false          nan         -nan OK
      log(-1.0+z)    NaN false  true    0  true         -nan         -nan OK
       sqrt(-1.0)    NaN false  true    0 false         -nan         -nan OK
     sqrt(-1.0+z)    NaN false  true    0  true         -nan         -nan OK
PIGLIT: {'result': 'fail' }

commit c189840b21e176d87cbb382e64e848061b8c7b06
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Tue Aug 13 15:03:12 2013 -0700

    i965: Force X-tiling for 128 bpp formats on Sandybridge.
    
    128 bpp formats are not allowed to be Y-tiled on any architectures
    except Gen7.
    
    +11 Piglits on Sandybridge (mostly regression fixes since the
    switch to Y-tiling).
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63867
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64261
    Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
    Cc: "9.2" <mesa-stable@lists.freedesktop.org>

By the way, the isinf-isnan continued failure was due to 68086.  That's fixed now too.

Verified.Fixed.