Bug 64262

Summary: [PNV Bisected] piglit glean_pointSprite core dumped
Product: Mesa Reporter: lu hua <huax.lu>
Component: Drivers/DRI/i915Assignee: Kenneth Graunke <kenneth>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: idr, xunx.fang
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 67224    

Description lu hua 2013-05-06 02:48:53 UTC 
System Environment:
--------------------------
Arch:             i386
Platform:         Pineview
Libdrm:		(master)2.4.44-6-g011999927f76a7e9ba8f047fae4b4e084da6c2c3
Mesa:		(master)abbbc9b667d1156a42a4e2bf4eee591f8ab2946f
Xserver:(master)xorg-server-1.14.99.1-37-g451ba4bd41b82acd4aec6236ba121e00cfeb311b
Xf86_video_intel:(master)2.21.6-25-g5637c173f85a5bb9a77572e4c070e0d612e6f49d
Cairo:		(master)32bd6aa46dc77c497f06d2ab3bf0c2ec218d9e19
Libva:		(staging)63182cd2c03019751b8a2ded17082324be143417
Libva_intel_driver:(staging)5bd630d4ea732818728b0a464f45739c86e08be3
Kernel:	(drm-intel-nightly) 040e2924d084ac3605d0e7f799d9ca71fc7b66c0

Bug detailed description:
-------------------------
It fails on pineview with mesa master branch. It works well on 9.1 branch.
Bisect shows:4df1b986d3e44dc035227054000a1d0e1846ef07 is the first bad commit.
commit 4df1b986d3e44dc035227054000a1d0e1846ef07
Author:     Eric Anholt <eric@anholt.net>
AuthorDate: Wed Apr 17 19:10:29 2013 -0700
Commit:     Eric Anholt <eric@anholt.net>
CommitDate: Mon Apr 29 11:41:33 2013 -0700

    i915: Add support for GL_EXT_texture_sRGB and GL_EXT_texture_sRGB_decode.

    This brings the driver up to GL 2.1.

output:
Test basic point sprite functionality.

Aborted (core dumped)

(gdb) bt
#0  0xb7fff424 in __kernel_vsyscall ()
#1  0x4417498f in raise () from /lib/libc.so.6
#2  0x441762d5 in abort () from /lib/libc.so.6
#3  0x080e066a in GLEAN::FindNonBlack (buf=0x835e5b0, w=40, h=40, x0=0xbffff038, y0=0xbffff034) at /GFX/Test/Piglit/piglit/tests/glean/tpointsprite.cpp:269
#4  0x080e06f0 in GLEAN::PointSpriteTest::ComparePixels (this=0x815c140, buf=0x835e5b0, pSize=4, coordOrigin=36001) at /GFX/Test/Piglit/piglit/tests/glean/tpointsprite.cpp:292
#5  0x080e0e37 in GLEAN::PointSpriteTest::runOne (this=0x815c140, r=..., w=...) at /GFX/Test/Piglit/piglit/tests/glean/tpointsprite.cpp:427
#6  0x080b05d8 in GLEAN::BaseTest<GLEAN::MultiTestResult>::run (this=0x815c140, environment=...) at /GFX/Test/Piglit/piglit/tests/glean/tbase.h:331
#7  0x080a9166 in main (argc=7, argv=0xbffff364) at /GFX/Test/Piglit/piglit/tests/glean/main.cpp:125

Reproduce steps:
----------------
1. xinit
2. ./bin/glean -o -v -v -v -t +pointSprit
Comment 1 Gordon Jin 2013-05-24 05:11:14 UTC 
Eric, can you reproduce?
Comment 2 Kenneth Graunke 2013-07-26 22:03:55 UTC 
I can reproduce this.
Comment 3 Kenneth Graunke 2013-07-26 22:38:59 UTC 
The test apparently calls abort() if it can't find any black pixels, i.e. nothing was drawn.  (This is rather stupid; it should fail, not abort...)

Exposing GL 2.0 caused Glean to start testing a GL_POINT_SPRITE_COORD_ORIGIN of GL_LOWER_LEFT, which fails.  Previously, it only tested GL_UPPER_LEFT, which appears to still work.

So the newly exposed functionality is broken, but the old functionality hasn't regressed as far as I can tell.
Comment 4 Ian Romanick 2013-07-27 05:45:13 UTC 
I'm in favor of fixing the test to not abort and taking the bug off the blocker list.
Comment 5 Ian Romanick 2013-08-08 18:18:10 UTC 
The segfault was a problem with the test case, and it is fixed by piglit commit ddff74c.  Point sprites don't work on Pineview, and this is already tracked by bug #23053.
Comment 6 lu hua 2013-08-12 06:14:25 UTC 
Verified.Fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.