Bug 65981

Summary:	Unbreak TpQtMacros.cmake with Ninja (cmake)
Product:	Telepathy	Reporter:	Jasper Lievisse Adriaanse <jasper>
Component:	tp-qt	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Unbreak with Ninja

Description Jasper Lievisse Adriaanse 2013-06-20 18:53:24 UTC

OpenBSD is switching it's cmake port to use ninja; this revealed an issue in cmake/modules/TpQtMacros.cmake which the attached patch fixes. Ninja is slightly stricter than regular cmake but the generated Makefile is still perfectly valid for GNU/BSD Make.

Patch was provided by David Coppa <dcoppa@openbsd.org>.

Comment 1 Jasper Lievisse Adriaanse 2013-06-20 18:54:02 UTC

Created attachment 81129 [details] [review]
Unbreak with Ninja

Comment 2 Alexandr Akulich 2016-06-12 11:24:56 UTC

I'm sorry I missed the bugreport and patch and made fix by myself.

This fixes Ninja build for me. Feel free to reopen the report if you have any issues.

My fix:
https://cgit.freedesktop.org/telepathy/telepathy-qt/commit/?id=d9354dfe8cca364e4a8c3a44c302ceb714c53911

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.