Bug 65981 - Unbreak TpQtMacros.cmake with Ninja (cmake)
Summary: Unbreak TpQtMacros.cmake with Ninja (cmake)
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 18:53 UTC by Jasper Lievisse Adriaanse
Modified: 2016-06-12 11:24 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Unbreak with Ninja (15.03 KB, patch)
2013-06-20 18:54 UTC, Jasper Lievisse Adriaanse 		Details | Splinter Review
View All

Description Jasper Lievisse Adriaanse 2013-06-20 18:53:24 UTC 
OpenBSD is switching it's cmake port to use ninja; this revealed an issue in cmake/modules/TpQtMacros.cmake which the attached patch fixes. Ninja is slightly stricter than regular cmake but the generated Makefile is still perfectly valid for GNU/BSD Make.

Patch was provided by David Coppa <dcoppa@openbsd.org>.
Comment 1 Jasper Lievisse Adriaanse 2013-06-20 18:54:02 UTC 
Created attachment 81129 [details] [review]
Unbreak with Ninja
Comment 2 Alexandr Akulich 2016-06-12 11:24:56 UTC 
I'm sorry I missed the bugreport and patch and made fix by myself.

This fixes Ninja build for me. Feel free to reopen the report if you have any issues.

My fix:
https://cgit.freedesktop.org/telepathy/telepathy-qt/commit/?id=d9354dfe8cca364e4a8c3a44c302ceb714c53911

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.