| Summary: | Bad reference images huge-radial.pdf.*.ref.png for huge-radial test | ||
|---|---|---|---|
| Product: | cairo | Reporter: | Bryce Harrington <bryce> |
| Component: | general | Assignee: | Bryce Harrington <bryce> |
| Status: | RESOLVED FIXED | QA Contact: | cairo-bugs mailing list <cairo-bugs> |
| Severity: | minor | ||
| Priority: | medium | ||
| Version: | 1.12.14 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 68382 | ||
| Attachments: |
Original output
0001-Drop-the-target-specific-huge-radial.pdf.-.ref.png-i.patch Screen clip of test suite page after the fix. orig.png fixed.png |
||
Created attachment 81489 [details] [review] 0001-Drop-the-target-specific-huge-radial.pdf.-.ref.png-i.patch Fixes issue by dropping the bogus reference images. The test suite will fall back to the more generic format-specific reference images, which still don't quite match test output, but look more sane. Created attachment 81490 [details]
Screen clip of test suite page after the fix.
Here's the test suite output showing that it falls back to the more generic huge-radial.*.ref.png reference images.
Testing huge-radial with pdf target (dev offset 0)
119644 pixels differ (with maximum difference of 255) from reference image
119644 pixels differ (with maximum difference of 255) from reference image
OUTPUT: output/huge-radial.pdf.argb32.out.png
REFERENCE: ./reference/huge-radial.argb32.ref.png
DIFFERENCE: output/huge-radial.pdf.argb32.diff.png
TEST: huge-radial TARGET: pdf FORMAT: argb32 OFFSET: 0 SIMILAR: 0 RESULT: FAIL
Testing huge-radial with pdf target (dev offset 0)
119644 pixels differ (with maximum difference of 255) from reference image
119644 pixels differ (with maximum difference of 255) from reference image
OUTPUT: output/huge-radial.pdf.rgb24.out.png
REFERENCE: ./reference/huge-radial.rgb24.ref.png
DIFFERENCE: output/huge-radial.pdf.rgb24.diff.png
TEST: huge-radial TARGET: pdf FORMAT: rgb24 OFFSET: 0 SIMILAR: 0 RESULT: FAIL
Created attachment 81495 [details]
orig.png
Created attachment 81496 [details]
fixed.png
Patch merged f7d0f80..b4e218c master -> master |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 81488 [details] Original output In comparing the target-specific reference images to their more generic format-specific reference images in the current git tree, I noticed the huge-radial test's reference images for the pdf target are clearly wrong, and worse than what the test is outputting. See orig.png screenshot clipping. Test output is as follows: Testing huge-radial with pdf target (dev offset 0) 119644 pixels differ (with maximum difference of 255) from reference image 117198 pixels differ (with maximum difference of 255) from reference image OUTPUT: output/huge-radial.pdf.argb32.out.png REFERENCE: ./reference/huge-radial.pdf.argb32.ref.png DIFFERENCE: output/huge-radial.pdf.argb32.diff.png TEST: huge-radial TARGET: pdf FORMAT: argb32 OFFSET: 0 SIMILAR: 0 RESULT: FAIL Testing huge-radial with pdf target (dev offset 0) 119644 pixels differ (with maximum difference of 255) from reference image 119205 pixels differ (with maximum difference of 255) from reference image OUTPUT: output/huge-radial.pdf.rgb24.out.png REFERENCE: ./reference/huge-radial.pdf.rgb24.ref.png DIFFERENCE: output/huge-radial.pdf.rgb24.diff.png TEST: huge-radial TARGET: pdf FORMAT: rgb24 OFFSET: 0 SIMILAR: 0 RESULT: FAIL