Bug 66218 - Bad reference images huge-radial.pdf.*.ref.png for huge-radial test
Summary: Bad reference images huge-radial.pdf.*.ref.png for huge-radial test
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.12.14
Hardware: All All
: medium minor
Assignee: Bryce Harrington
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: cairo-1.14
  Show dependency treegraph
 
Reported: 2013-06-26 17:06 UTC by Bryce Harrington
Modified: 2014-10-29 22:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Original output (127.11 KB, text/plain)
2013-06-26 17:06 UTC, Bryce Harrington
Details
0001-Drop-the-target-specific-huge-radial.pdf.-.ref.png-i.patch (504.69 KB, patch)
2013-06-26 17:17 UTC, Bryce Harrington
Details | Splinter Review
Screen clip of test suite page after the fix. (66.42 KB, text/plain)
2013-06-26 17:19 UTC, Bryce Harrington
Details
orig.png (127.11 KB, image/png)
2013-06-26 18:46 UTC, Bryce Harrington
Details
fixed.png (66.42 KB, image/png)
2013-06-26 18:47 UTC, Bryce Harrington
Details

Description Bryce Harrington 2013-06-26 17:06:06 UTC
Created attachment 81488 [details]
Original output

In comparing the target-specific reference images to their more generic format-specific reference images in the current git tree, I noticed the huge-radial test's reference images for the pdf target are clearly wrong, and worse than what the test is outputting.  See orig.png screenshot clipping.

Test output is as follows:

Testing huge-radial with pdf target (dev offset 0)
119644 pixels differ (with maximum difference of 255) from reference image
117198 pixels differ (with maximum difference of 255) from reference image
OUTPUT: output/huge-radial.pdf.argb32.out.png
REFERENCE: ./reference/huge-radial.pdf.argb32.ref.png
DIFFERENCE: output/huge-radial.pdf.argb32.diff.png
TEST: huge-radial TARGET: pdf FORMAT: argb32 OFFSET: 0 SIMILAR: 0 RESULT: FAIL

Testing huge-radial with pdf target (dev offset 0)
119644 pixels differ (with maximum difference of 255) from reference image
119205 pixels differ (with maximum difference of 255) from reference image
OUTPUT: output/huge-radial.pdf.rgb24.out.png
REFERENCE: ./reference/huge-radial.pdf.rgb24.ref.png
DIFFERENCE: output/huge-radial.pdf.rgb24.diff.png
TEST: huge-radial TARGET: pdf FORMAT: rgb24 OFFSET: 0 SIMILAR: 0 RESULT: FAIL
Comment 1 Bryce Harrington 2013-06-26 17:17:05 UTC
Created attachment 81489 [details] [review]
0001-Drop-the-target-specific-huge-radial.pdf.-.ref.png-i.patch

Fixes issue by dropping the bogus reference images.

The test suite will fall back to the more generic format-specific reference images, which still don't quite match test output, but look more sane.
Comment 2 Bryce Harrington 2013-06-26 17:19:06 UTC
Created attachment 81490 [details]
Screen clip of test suite page after the fix.

Here's the test suite output showing that it falls back to the more generic huge-radial.*.ref.png reference images.

Testing huge-radial with pdf target (dev offset 0)
119644 pixels differ (with maximum difference of 255) from reference image
119644 pixels differ (with maximum difference of 255) from reference image
OUTPUT: output/huge-radial.pdf.argb32.out.png
REFERENCE: ./reference/huge-radial.argb32.ref.png
DIFFERENCE: output/huge-radial.pdf.argb32.diff.png
TEST: huge-radial TARGET: pdf FORMAT: argb32 OFFSET: 0 SIMILAR: 0 RESULT: FAIL

Testing huge-radial with pdf target (dev offset 0)
119644 pixels differ (with maximum difference of 255) from reference image
119644 pixels differ (with maximum difference of 255) from reference image
OUTPUT: output/huge-radial.pdf.rgb24.out.png
REFERENCE: ./reference/huge-radial.rgb24.ref.png
DIFFERENCE: output/huge-radial.pdf.rgb24.diff.png
TEST: huge-radial TARGET: pdf FORMAT: rgb24 OFFSET: 0 SIMILAR: 0 RESULT: FAIL
Comment 3 Bryce Harrington 2013-06-26 18:46:57 UTC
Created attachment 81495 [details]
orig.png
Comment 4 Bryce Harrington 2013-06-26 18:47:26 UTC
Created attachment 81496 [details]
fixed.png
Comment 5 Bryce Harrington 2014-10-29 22:46:45 UTC
Patch merged
   f7d0f80..b4e218c  master -> master


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.