Bug 67055

Summary: Pidgin's buddyicon corrupts when resizing the main window horizontally [SNA]
Product: xorg Reporter: Clemens Eisserer <linuxhippy>
Component: Driver/intelAssignee: Chris Wilson <chris>
Status: RESOLVED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
screenshot
none
Try more exposes none

Description Clemens Eisserer 2013-07-18 18:27:14 UTC
When resizing Pidgin's main window horizointally on my laptop (intel git, linux-3.11rc1, Fedora-19, XFCE without composition manager), the buddy-icon corrupts

This issue is quite tricky to reproduce, as on my system the issue is only reproduceable when I am online with both IM accounts  (ICQ and Jabber) - I guess it has something to do with the amount of entries in the list.
However I saw the corruption with various gtk themes.

I was able to track the issue down to: 

07926bfe507071a3d46a2ec13bb86a36bc225761 is the first bad commit
commit 07926bfe507071a3d46a2ec13bb86a36bc225761
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Jul 11 15:28:55 2013 +0100

    sna: Remove the temporary region allocation from sna_do_copy
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

:040000 040000 e3bd9b3f91d8c96342eb1196ff9230a348d3d054 b33919d78a5e4c556f63384ce61f015d90b903fc M	src
Comment 1 Clemens Eisserer 2013-07-18 18:27:38 UTC
Created attachment 82624 [details]
screenshot
Comment 2 Chris Wilson 2013-07-18 20:26:28 UTC
Just double check with master, as I am pretty sure I have the regression from that patch fixed.
Comment 3 Clemens Eisserer 2013-07-18 20:30:18 UTC
nope, still there with 	6c8b15d321044d4a81cb187cc5e1ac094eb82367
Comment 4 Chris Wilson 2013-07-18 21:01:23 UTC
Created attachment 82637 [details] [review]
Try more exposes

Here's an idea, maybe we are missing an expose?
Comment 5 Clemens Eisserer 2013-07-18 21:21:01 UTC
Unfortunately not :/
Comment 6 Chris Wilson 2013-07-19 09:47:16 UTC
Possible lead:

Christoph Reiter 2013-07-19 09:33:16 UTC

https://bugs.freedesktop.org/attachment.cgi?id=82672

another maybe related problem:

 - start geany with a large enough text file to have a scrollbar
 - ctrl+f
 - place search window on top of text area
 - scroll down
 - screenshot attached (bug2.png)
Comment 7 Chris Wilson 2013-07-19 14:11:12 UTC
Best guess at the issue:

commit 2d62f7c483a999c24c744c0d257c8524f6fd5d32
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Jul 18 22:00:24 2013 +0100

    sna: Also do exposure checking after source clipping in sna_do_copy
    
    Hopefully a final regression from:
    
    commit 07926bfe507071a3d46a2ec13bb86a36bc225761
    Author: Chris Wilson <chris@chris-wilson.co.uk>
    Date:   Thu Jul 11 15:28:55 2013 +0100
    
        sna: Remove the temporary region allocation from sna_do_copy
    
    References: https://bugs.freedesktop.org/show_bug.cgi?id=67055
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>


Still uncertain.
Comment 8 Chris Wilson 2013-07-21 14:05:53 UTC
Many attempts to fixup the potential issue in sna_do_copy() - please do test. :)
Comment 9 Chris Wilson 2013-08-11 11:52:19 UTC
Presuming fixed.
Comment 10 Clemens Eisserer 2013-08-12 12:42:51 UTC
sorry for the lack of feedback - I can confirm its fixed.
Thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.