| Summary: | Other: Writer: Wrong Flip menu items and icons | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Stanislav Horacek <stanislav.horacek> |
| Component: | UI | Assignee: | Joel Madero <jmadero.dev> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | lowest | CC: | jmadero.dev, timofeev.i.s |
| Version: | 4.1.0.4 release | Keywords: | regression |
| Hardware: | Other | ||
| OS: | Linux (All) | ||
| Whiteboard: | BSA target:4.2.0 target:4.1.2 | ||
| i915 platform: | i915 features: | ||
| Attachments: | screenshot of the menu | ||
Ah - there is the other one - confirmed and taking it Joel Madero committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d9ead65397ea4b6d4bcc66cf304653bb71e14c9c fdo#67584 - Incorrect Flip Labels The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Checked in master (Build ID: 1e379e3c9aa62c6cf46c32175d5e8c9d4f4bca09): Labels are OK now, but - could it be "Flip Vertically" and "Flip Horizontally" instead of "Flip horizontal"? The icons are still swapped. I'm not sure if we actually pushed the fix here - I made a mistake with the icons and need to revisit it. Will try to investigate To the icons: it depends on icon theme. Themes galaxy and hicontrast are right, all others have vertical and horizontal flip icon swapped. So, this is a regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=c991fb49aa174f300be0b978d89bc63e01e0aa2b uno:FlipHorizontal was removed from WriterCommands.xcu, I guess uno:FlipVertical just need to be removed too. I will try that... I've just swapped the icons - there was an old bug 42434. Ivan Timofeev committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=65c85266ce1f8b12a33dfaa8efff365854f17dd5 fdo#67584: remove .uno:FlipVertical from WriterCommands.xcu The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Is this bug 100% fixed now? I thought my patch took care of most of it other than the minor label issue and I had sym links for icons -- which I was going to take care of. But if you've solved all of it I'll mark as FIXED Yes, but I usually delay closing until a fix is backported to release branches. :) The label is fixed here and the icons are fixed in bug 42434. Ivan Timofeev committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d04e98d4ef8d15c9e8c76d0a61fd0aa45e75b1e8&h=libreoffice-4-1 fdo#67584: remove .uno:FlipVertical from WriterCommands.xcu It will be available in LibreOffice 4.1.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Checked in 4.1 (Build ID: aa9bef8271ed50a397c959ed53c91ee44b3dcb1) and master (Build ID: dda8877b989ebe330315e94523b983a6803e1372) - both labels and icons are OK; marking as verified. Thank you for solving this! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 83364 [details] screenshot of the menu Problem description: Steps to reproduce: 1. In Writer, choose Format - Flip. Current behavior: You see "Flip Horizontally" and "Flip Horizontally" items and icons with horizontal and vertical arrowed line. Expected behavior: You should see "Flip Vertically" and "Flip Horizontally" items and icons with vertical and horizontal arrowed line. Operating System: Ubuntu Version: 4.1.0.4 release Last worked in: 4.0.2.2 release