Bug 68165

Created attachment 84116 [details]
dmesg of booting and testdisplay -f on SNB mobile

Reassigning to Daniel.

Can you please attach attach debug dmesg for both a working kernel and a broken kernel with booting+testdisplay -f? It's unclear to me whether the attached dmesg is a working kernel or not ...

(In reply to comment #3)
> Can you please attach attach debug dmesg for both a working kernel and a
> broken kernel with booting+testdisplay -f? It's unclear to me whether the
> attached dmesg is a working kernel or not ...

Actually, the attachment I attached is the first bad commit fae5cbff3e3e4097de2e76178d462b90626c2bdb kernel's dmesg..

I do it again with a good commit ef3efb46e7c157c777fd91905aae771e92b61473 and a bad commit fae5cbff3e3e4097de2e76178d462b90626c2bdb on a SNB platform.

Created attachment 84216 [details]
good kernel dmesg

Created attachment 84217 [details]
bad kernel dmesg

Can you please retest on latest kernels with

commit a52690e445637dda7f71878965d64d9b6a15a2b7
Author: Imre Deak <imre.deak@intel.com>
Date:   Tue Aug 27 12:24:09 2013 +0300

    drm/i915: fix lvds/dp panel fitter setting

(In reply to comment #7)
> Can you please retest on latest kernels with
> 
> commit a52690e445637dda7f71878965d64d9b6a15a2b7
> Author: Imre Deak <imre.deak@intel.com>
> Date:   Tue Aug 27 12:24:09 2013 +0300
> 
>     drm/i915: fix lvds/dp panel fitter setting

This issue's gone with latest kernels, so I think we could close this bug. :)

Please apply this on top of latest (working!) kernels. If it brings back the issue again, we can safely close the bug. Thanks.

diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index 293564a..5df872f 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -40,8 +40,6 @@ intel_fixed_panel_mode(const struct drm_display_mode *fixed_mode,
 		       struct drm_display_mode *adjusted_mode)
 {
 	drm_mode_copy(adjusted_mode, fixed_mode);
-
-	drm_mode_set_crtcinfo(adjusted_mode, 0);
 }
 
 /* adjusted_mode has been preset to be the panel's fixed mode */

I think we can just close this ;-)

(In reply to comment #10)
> I think we can just close this ;-)

I can't reproduce it on IVB/HSW platform, but in this kernel testing, I find it still exits on SNB platform. So I reopened it.

(In reply to comment #11)
> (In reply to comment #10)
> > I think we can just close this ;-)
> 
> I can't reproduce it on IVB/HSW platform, but in this kernel testing, I find
> it still exits on SNB platform. So I reopened it.

Hmm..I'm sorry I came to the conclusion too fast, this issue can't be reproduced on our latest kernel, it's just on testing kernel. Sorry, please close it again...

(In reply to comment #9)
> Please apply this on top of latest (working!) kernels. If it brings back the
> issue again, we can safely close the bug. Thanks.
> 
> diff --git a/drivers/gpu/drm/i915/intel_panel.c
> b/drivers/gpu/drm/i915/intel_panel.c
> index 293564a..5df872f 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -40,8 +40,6 @@ intel_fixed_panel_mode(const struct drm_display_mode
> *fixed_mode,
>  		       struct drm_display_mode *adjusted_mode)
>  {
>  	drm_mode_copy(adjusted_mode, fixed_mode);
> -
> -	drm_mode_set_crtcinfo(adjusted_mode, 0);
>  }
>  
>  /* adjusted_mode has been preset to be the panel's fixed mode */

Hi, I applied this patch on latest kernel and retested it. I can't tell if it can bring back the issue because system boots up with eDP black. Does this what we expect?

Yup, I think this all fits and we can close this.

Closing old verified.