Bug 68165 - [SNB eDP bisected]I-G-T/testdisplay -f causes eDP black
Summary: [SNB eDP bisected]I-G-T/testdisplay -f causes eDP black
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other All
: medium major
Assignee: Daniel Vetter
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 01:51 UTC by cancan,feng
Modified: 2017-10-06 14:44 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg of booting and testdisplay -f on SNB mobile (112.99 KB, text/plain)
2013-08-16 02:20 UTC, cancan,feng
no flags Details
good kernel dmesg (105.92 KB, text/plain)
2013-08-19 01:20 UTC, cancan,feng
no flags Details
bad kernel dmesg (105.93 KB, text/plain)
2013-08-19 01:21 UTC, cancan,feng
no flags Details

Description cancan,feng 2013-08-16 01:51:56 UTC
Description:
--------------------
I-G-T/testdisplay -f doesn't work on eDP pipe, eDP screen will turn to black after do this operation. This issue happens on SNB, IVB and HSW mobile. I bisected on a SNB mobile, here is the bisect result:

commit fae5cbff3e3e4097de2e76178d462b90626c2bdb
Author:     Daniel Vetter <daniel.vetter@ffwll.ch>
AuthorDate: Sun Jul 21 21:37:09 2013 +0200
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Sat Jul 27 00:02:38 2013 +0200

    drm/i915: clean up crtc timings computation


Reproduce step:
----------------------
1. testdisplay -f 38.25,800,832,912,1024,600,603,607,624
Comment 1 cancan,feng 2013-08-16 02:20:08 UTC
Created attachment 84116 [details]
dmesg of booting and testdisplay -f on SNB mobile
Comment 2 Paulo Zanoni 2013-08-16 21:04:34 UTC
Reassigning to Daniel.
Comment 3 Daniel Vetter 2013-08-18 17:43:37 UTC
Can you please attach attach debug dmesg for both a working kernel and a broken kernel with booting+testdisplay -f? It's unclear to me whether the attached dmesg is a working kernel or not ...
Comment 4 cancan,feng 2013-08-19 01:19:55 UTC
(In reply to comment #3)
> Can you please attach attach debug dmesg for both a working kernel and a
> broken kernel with booting+testdisplay -f? It's unclear to me whether the
> attached dmesg is a working kernel or not ...

Actually, the attachment I attached is the first bad commit fae5cbff3e3e4097de2e76178d462b90626c2bdb kernel's dmesg..

I do it again with a good commit ef3efb46e7c157c777fd91905aae771e92b61473 and a bad commit fae5cbff3e3e4097de2e76178d462b90626c2bdb on a SNB platform.
Comment 5 cancan,feng 2013-08-19 01:20:33 UTC
Created attachment 84216 [details]
good kernel dmesg
Comment 6 cancan,feng 2013-08-19 01:21:08 UTC
Created attachment 84217 [details]
bad kernel dmesg
Comment 7 Daniel Vetter 2013-09-09 09:13:21 UTC
Can you please retest on latest kernels with

commit a52690e445637dda7f71878965d64d9b6a15a2b7
Author: Imre Deak <imre.deak@intel.com>
Date:   Tue Aug 27 12:24:09 2013 +0300

    drm/i915: fix lvds/dp panel fitter setting
Comment 8 cancan,feng 2013-09-10 01:08:19 UTC
(In reply to comment #7)
> Can you please retest on latest kernels with
> 
> commit a52690e445637dda7f71878965d64d9b6a15a2b7
> Author: Imre Deak <imre.deak@intel.com>
> Date:   Tue Aug 27 12:24:09 2013 +0300
> 
>     drm/i915: fix lvds/dp panel fitter setting

This issue's gone with latest kernels, so I think we could close this bug. :)
Comment 9 Jani Nikula 2013-09-10 09:38:31 UTC
Please apply this on top of latest (working!) kernels. If it brings back the issue again, we can safely close the bug. Thanks.

diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index 293564a..5df872f 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -40,8 +40,6 @@ intel_fixed_panel_mode(const struct drm_display_mode *fixed_mode,
 		       struct drm_display_mode *adjusted_mode)
 {
 	drm_mode_copy(adjusted_mode, fixed_mode);
-
-	drm_mode_set_crtcinfo(adjusted_mode, 0);
 }
 
 /* adjusted_mode has been preset to be the panel's fixed mode */
Comment 10 Daniel Vetter 2013-09-10 11:16:43 UTC
I think we can just close this ;-)
Comment 11 cancan,feng 2013-09-12 06:32:01 UTC
(In reply to comment #10)
> I think we can just close this ;-)

I can't reproduce it on IVB/HSW platform, but in this kernel testing, I find it still exits on SNB platform. So I reopened it.
Comment 12 cancan,feng 2013-09-12 07:36:19 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > I think we can just close this ;-)
> 
> I can't reproduce it on IVB/HSW platform, but in this kernel testing, I find
> it still exits on SNB platform. So I reopened it.

Hmm..I'm sorry I came to the conclusion too fast, this issue can't be reproduced on our latest kernel, it's just on testing kernel. Sorry, please close it again...
Comment 13 cancan,feng 2013-09-12 07:42:25 UTC
(In reply to comment #9)
> Please apply this on top of latest (working!) kernels. If it brings back the
> issue again, we can safely close the bug. Thanks.
> 
> diff --git a/drivers/gpu/drm/i915/intel_panel.c
> b/drivers/gpu/drm/i915/intel_panel.c
> index 293564a..5df872f 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -40,8 +40,6 @@ intel_fixed_panel_mode(const struct drm_display_mode
> *fixed_mode,
>  		       struct drm_display_mode *adjusted_mode)
>  {
>  	drm_mode_copy(adjusted_mode, fixed_mode);
> -
> -	drm_mode_set_crtcinfo(adjusted_mode, 0);
>  }
>  
>  /* adjusted_mode has been preset to be the panel's fixed mode */

Hi, I applied this patch on latest kernel and retested it. I can't tell if it can bring back the issue because system boots up with eDP black. Does this what we expect?
Comment 14 Daniel Vetter 2013-09-12 08:41:48 UTC
Yup, I think this all fits and we can close this.
Comment 15 Elizabeth 2017-10-06 14:44:03 UTC
Closing old verified.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.