| Summary: | test/Makefile.am:106: error: installable_manual_tests must be set with '=' before using '+=' | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Colin Walters <walters> |
| Component: | core | Assignee: | Havoc Pennington <hp> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | walters |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | 0001-test-Fix-build.patch | ||
|
Description
Colin Walters
2013-08-23 01:08:15 UTC
Concretely the gnome-ostree build broke: http://build.gnome.org/ostree/buildmaster/tasks/build/failed/20130823.4/output.txt Created attachment 84482 [details] [review] 0001-test-Fix-build.patch Comment on attachment 84482 [details] [review] 0001-test-Fix-build.patch Review of attachment 84482 [details] [review]: ----------------------------------------------------------------- Sure. As a matter of coding style I usually prefer foo = or foo = \ $(NULL) depending whether I expect the list to become non-empty - the only purpose of writing $(NULL) is to reduce diff/conflicts, by not having the last item of a list be a special case (which results in 2 lines changing when 1 line is appended). Ralf already fixed this, in fact. Fixed in git for 1.7.6 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.