Bug 68458 - test/Makefile.am:106: error: installable_manual_tests must be set with '=' before using '+='
Summary: test/Makefile.am:106: error: installable_manual_tests must be set with '=' be...
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-23 01:08 UTC by Colin Walters
Modified: 2013-08-23 10:48 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
0001-test-Fix-build.patch (685 bytes, patch)
2013-08-23 01:13 UTC, Colin Walters
Details | Splinter Review

Description Colin Walters 2013-08-23 01:08:15 UTC
Regression from 9c0a70f5a3faa6a76e9a06e4e192ce551d7b880c ?
Comment 1 Colin Walters 2013-08-23 01:08:28 UTC
Concretely the gnome-ostree build broke:

http://build.gnome.org/ostree/buildmaster/tasks/build/failed/20130823.4/output.txt
Comment 2 Colin Walters 2013-08-23 01:13:13 UTC
Created attachment 84482 [details] [review]
0001-test-Fix-build.patch
Comment 3 Simon McVittie 2013-08-23 09:03:29 UTC
Comment on attachment 84482 [details] [review]
0001-test-Fix-build.patch

Review of attachment 84482 [details] [review]:
-----------------------------------------------------------------

Sure.

As a matter of coding style I usually prefer

foo =

or

foo = \
    $(NULL)

depending whether I expect the list to become non-empty - the only purpose of writing $(NULL) is to reduce diff/conflicts, by not having the last item of a list be a special case (which results in 2 lines changing when 1 line is appended).
Comment 4 Simon McVittie 2013-08-23 09:44:59 UTC
Ralf already fixed this, in fact.
Comment 5 Simon McVittie 2013-08-23 10:48:09 UTC
Fixed in git for 1.7.6


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.