| Summary: | Use the self-TpContact to track presence | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | mission-control | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
1/2] Track presence via TpContact, not McdConnection
2/2] Add a regression test for a "no SimplePresence" special case |
||
|
Description
Simon McVittie
2013-09-03 19:11:50 UTC
Created attachment 85142 [details] [review] 1/2] Track presence via TpContact, not McdConnection Now that McdAccount has a TpContact for the self-contact, this is really easy. --- src/mcd-account.c | 68 ++++++++++++++++++++++------------------------------ src/mcd-connection.c | 67 --------------------------------------------------- 2 files changed, 29 insertions(+), 106 deletions(-) Created attachment 85143 [details] [review] 2/2] Add a regression test for a "no SimplePresence" special case CurrentPresence should toggle between OFFLINE and UNSET if the account has no concept of presence. --- This already worked, but we didn't test it. Comment on attachment 85142 [details] [review] 1/2] Track presence via TpContact, not McdConnection Review of attachment 85142 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 85143 [details] [review] 2/2] Add a regression test for a "no SimplePresence" special case Review of attachment 85143 [details] [review]: ----------------------------------------------------------------- ++ Fixed in git master for 5.15.1. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.