| Summary: | Failed to create huge image with pixman_image_create_bits | ||
|---|---|---|---|
| Product: | pixman | Reporter: | LE GARREC Vincent <freedesktop> |
| Component: | pixman | Assignee: | Søren Sandmann Pedersen <soren.sandmann> |
| Status: | RESOLVED MOVED | QA Contact: | Søren Sandmann Pedersen <soren.sandmann> |
| Severity: | normal | ||
| Priority: | medium | CC: | siarhei.siamashka |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Patch allowing create huge image
patch helping pixman-bits-image.c with huge image |
||
Thanks for the bug report.
The patch looks right to me, but for us to merge it, it needs to be sent to the mailing list at
pixman@lists.freedesktop.org
with a commit log. The command
git send-email
can be used for this, or, if your git setup can't send mail, then
git format-patch
to generate a patch that can be included in a mail.
Created attachment 85448 [details] [review] patch helping pixman-bits-image.c with huge image I thing the patch must be bigger than the first I made to help pixman support big image. Every multiplication by stride should be cast. What do you think about my second patch ? I only modify pixman-bits-image.c. I'll make the change for all files after your feedback. The discussion needs to take place on the mailing list. (In reply to comment #3) > The discussion needs to take place on the mailing list. The discussion in the mailing list archives: http://lists.freedesktop.org/archives/pixman/2013-September/002915.html -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pixman/pixman/issues/6. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 85306 [details] Patch allowing create huge image I think there's a problem with the create_bits function. The buf_size is only right if under 2^31. The cast should be explicit like : buf_size = (size_t)height * stride;