Bug 69014 - Failed to create huge image with pixman_image_create_bits
Summary: Failed to create huge image with pixman_image_create_bits
Status: RESOLVED MOVED
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Søren Sandmann Pedersen
QA Contact: Søren Sandmann Pedersen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-06 06:20 UTC by LE GARREC Vincent
Modified: 2018-06-05 15:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch allowing create huge image (408 bytes, text/plain)
2013-09-06 06:20 UTC, LE GARREC Vincent
Details
patch helping pixman-bits-image.c with huge image (3.03 KB, patch)
2013-09-08 19:14 UTC, LE GARREC Vincent
Details | Splinter Review

Description LE GARREC Vincent 2013-09-06 06:20:14 UTC
Created attachment 85306 [details]
Patch allowing create huge image

I think there's a problem with the create_bits function. The buf_size is only right if under 2^31. The cast should be explicit like :

buf_size = (size_t)height * stride;
Comment 1 Søren Sandmann Pedersen 2013-09-08 17:50:04 UTC
Thanks for the bug report.

The patch looks right to me, but for us to merge it, it needs to be sent to the mailing list at 

    pixman@lists.freedesktop.org

with a commit log. The command

    git send-email

can be used for this, or, if your git setup can't send mail, then

    git format-patch

to generate a patch that can be included in a mail.
Comment 2 LE GARREC Vincent 2013-09-08 19:14:38 UTC
Created attachment 85448 [details] [review]
patch helping pixman-bits-image.c with huge image

I thing the patch must be bigger than the first I made to help pixman support big image. Every multiplication by stride should be cast. What do you think about my second patch ? I only modify pixman-bits-image.c. I'll make the change for all files after your feedback.
Comment 3 Søren Sandmann Pedersen 2013-09-08 23:21:03 UTC
The discussion needs to take place on the mailing list.
Comment 4 Siarhei Siamashka 2014-09-21 21:58:53 UTC
(In reply to comment #3)
> The discussion needs to take place on the mailing list.

The discussion in the mailing list archives: http://lists.freedesktop.org/archives/pixman/2013-September/002915.html
Comment 5 GitLab Migration User 2018-06-05 15:26:58 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pixman/pixman/issues/6.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.