Bug 6912

Summary:	PopplerAction family is not GLib-ish
Product:	poppler	Reporter:	Kouhei Sutou <kou>
Component:	glib frontend	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED NOTABUG	QA Contact:
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	an implementation of GObject-ized PopplerAction family an implementation of GObject-ized PopplerAction family (ver. 2) re-generated patch for 2006-05-21 CVS HEAD

Description Kouhei Sutou 2006-05-14 13:41:01 UTC

PopplerAction family has class hierarchy represented by union. But this is not
GLib-ish. We should use GObject to represent class hierarchy and the class
hierarchy represented by GObject helps us making language bindings.

Comment 1 Kouhei Sutou 2006-05-14 13:46:08 UTC

Created attachment 5620 [details] [review]
an implementation of GObject-ized PopplerAction family

This patch breakes backward compatibility.

Comment 2 Kouhei Sutou 2006-05-14 13:52:06 UTC

Created attachment 5621 [details] [review]
an implementation of GObject-ized PopplerAction family (ver. 2)

This patch fixes a bug in the previous patch; This patch uses g_object_unref()
instead of deprecated function poppler_action_free().

Comment 3 Kouhei Sutou 2006-05-21 23:17:59 UTC

Created attachment 5707 [details] [review]
re-generated patch for 2006-05-21 CVS HEAD

Comment 4 Kouhei Sutou 2006-09-22 17:44:24 UTC

I withdraw this request.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.