Bug 6912 - PopplerAction family is not GLib-ish
Summary: PopplerAction family is not GLib-ish
Status: RESOLVED NOTABUG
Alias: None
Product: poppler
Classification: Unclassified
Component: glib frontend (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-14 13:41 UTC by Kouhei Sutou
Modified: 2006-09-22 17:44 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
an implementation of GObject-ized PopplerAction family (36.38 KB, patch)
2006-05-14 13:46 UTC, Kouhei Sutou 		Details | Splinter Review
an implementation of GObject-ized PopplerAction family (ver. 2) (36.43 KB, patch)
2006-05-14 13:52 UTC, Kouhei Sutou 		Details | Splinter Review
re-generated patch for 2006-05-21 CVS HEAD (36.53 KB, patch)
2006-05-21 23:17 UTC, Kouhei Sutou 		Details | Splinter Review
Show Obsolete (2) View All

Description Kouhei Sutou 2006-05-14 13:41:01 UTC 
PopplerAction family has class hierarchy represented by union. But this is not
GLib-ish. We should use GObject to represent class hierarchy and the class
hierarchy represented by GObject helps us making language bindings.
Comment 1 Kouhei Sutou 2006-05-14 13:46:08 UTC 
Created attachment 5620 [details] [review]
an implementation of GObject-ized PopplerAction family

This patch breakes backward compatibility.
Comment 2 Kouhei Sutou 2006-05-14 13:52:06 UTC 
Created attachment 5621 [details] [review]
an implementation of GObject-ized PopplerAction family (ver. 2)

This patch fixes a bug in the previous patch; This patch uses g_object_unref()
instead of deprecated function poppler_action_free().
Comment 3 Kouhei Sutou 2006-05-21 23:17:59 UTC 
Created attachment 5707 [details] [review]
re-generated patch for 2006-05-21 CVS HEAD
Comment 4 Kouhei Sutou 2006-09-22 17:44:24 UTC 
I withdraw this request.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.