| Summary: | Fix Idle tests with recent automake | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | idle | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | guillaume.desmottes |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
.gitignore: automake 1.13 copies in /test-driver
Import run-test.sh.in from Gabble master Run regression tests under the run-test.sh "driver" .gitignore: update with new test files |
||
|
Description
Guillaume Desmottes
2013-09-12 08:57:15 UTC
Created attachment 85695 [details] [review] .gitignore: automake 1.13 copies in /test-driver Created attachment 85696 [details] [review] Import run-test.sh.in from Gabble master Created attachment 85697 [details] [review] Run regression tests under the run-test.sh "driver" Created attachment 85698 [details] [review] .gitignore: update with new test files Comment on attachment 85697 [details] [review] Run regression tests under the run-test.sh "driver" Review of attachment 85697 [details] [review]: ----------------------------------------------------------------- ::: tests/twisted/Makefile.am @@ +37,5 @@ > +config.py: Makefile > + $(AM_V_GEN) { \ > + echo "PACKAGE_STRING = \"$(PACKAGE_STRING)\""; \ > + echo "PLUGINS_ENABLED = $(PLUGINS_ENABLED_PYBOOL)"; \ > + } > $@ What's this bit for? Is it copypasta from Gabble, or needed? It looks as though we didn't have a config.py before, and I'm pretty sure Idle doesn't actually have plugins. (I wouldn't mind generating an empty config.py if you think it's useful to have the infrastructure ready for use, though.) Everything else here looks fine. (In reply to comment #5) > Comment on attachment 85697 [details] [review] [review] > Run regression tests under the run-test.sh "driver" > > Review of attachment 85697 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: tests/twisted/Makefile.am > @@ +37,5 @@ > > +config.py: Makefile > > + $(AM_V_GEN) { \ > > + echo "PACKAGE_STRING = \"$(PACKAGE_STRING)\""; \ > > + echo "PLUGINS_ENABLED = $(PLUGINS_ENABLED_PYBOOL)"; \ > > + } > $@ > > What's this bit for? Is it copypasta from Gabble, or needed? It looks as > though we didn't have a config.py before, and I'm pretty sure Idle doesn't > actually have plugins. > > (I wouldn't mind generating an empty config.py if you think it's useful to > have the infrastructure ready for use, though.) Yeah I copied the 'BUILT_SOURCES' section from Gabble which was generating a config.py. I'll remove PLUGINS_ENABLED as it's indeed useless here and merge. Merged to master; thanks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.