Bug 69258 - Fix Idle tests with recent automake
Summary: Fix Idle tests with recent automake
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: idle (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-12 08:57 UTC by Guillaume Desmottes
Modified: 2013-09-12 11:19 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
.gitignore: automake 1.13 copies in /test-driver (625 bytes, patch)
2013-09-12 08:58 UTC, Guillaume Desmottes 		Details | Splinter Review
Import run-test.sh.in from Gabble master (2.67 KB, patch)
2013-09-12 08:58 UTC, Guillaume Desmottes 		Details | Splinter Review
Run regression tests under the run-test.sh "driver" (5.65 KB, patch)
2013-09-12 08:59 UTC, Guillaume Desmottes 		Details | Splinter Review
.gitignore: update with new test files (1009 bytes, patch)
2013-09-12 08:59 UTC, Guillaume Desmottes 		Details | Splinter Review
View All

Description Guillaume Desmottes 2013-09-12 08:57:15 UTC 
.
Comment 1 Guillaume Desmottes 2013-09-12 08:58:40 UTC 
Created attachment 85695 [details] [review]
.gitignore: automake 1.13 copies in /test-driver
Comment 2 Guillaume Desmottes 2013-09-12 08:58:57 UTC 
Created attachment 85696 [details] [review]
Import run-test.sh.in from Gabble master
Comment 3 Guillaume Desmottes 2013-09-12 08:59:12 UTC 
Created attachment 85697 [details] [review]
Run regression tests under the run-test.sh "driver"
Comment 4 Guillaume Desmottes 2013-09-12 08:59:25 UTC 
Created attachment 85698 [details] [review]
.gitignore: update with new test files
Comment 5 Simon McVittie 2013-09-12 10:21:09 UTC 
Comment on attachment 85697 [details] [review]
Run regression tests under the run-test.sh "driver"

Review of attachment 85697 [details] [review]:
-----------------------------------------------------------------

::: tests/twisted/Makefile.am
@@ +37,5 @@
> +config.py: Makefile
> +	$(AM_V_GEN) { \
> +		echo "PACKAGE_STRING = \"$(PACKAGE_STRING)\""; \
> +		echo "PLUGINS_ENABLED = $(PLUGINS_ENABLED_PYBOOL)"; \
> +	} > $@

What's this bit for? Is it copypasta from Gabble, or needed? It looks as though we didn't have a config.py before, and I'm pretty sure Idle doesn't actually have plugins.

(I wouldn't mind generating an empty config.py if you think it's useful to have the infrastructure ready for use, though.)
Comment 6 Simon McVittie 2013-09-12 10:21:36 UTC 
Everything else here looks fine.
Comment 7 Guillaume Desmottes 2013-09-12 11:15:30 UTC 
(In reply to comment #5)
> Comment on attachment 85697 [details] [review] [review]
> Run regression tests under the run-test.sh "driver"
> 
> Review of attachment 85697 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: tests/twisted/Makefile.am
> @@ +37,5 @@
> > +config.py: Makefile
> > +	$(AM_V_GEN) { \
> > +		echo "PACKAGE_STRING = \"$(PACKAGE_STRING)\""; \
> > +		echo "PLUGINS_ENABLED = $(PLUGINS_ENABLED_PYBOOL)"; \
> > +	} > $@
> 
> What's this bit for? Is it copypasta from Gabble, or needed? It looks as
> though we didn't have a config.py before, and I'm pretty sure Idle doesn't
> actually have plugins.
> 
> (I wouldn't mind generating an empty config.py if you think it's useful to
> have the infrastructure ready for use, though.)

Yeah I copied the 'BUILT_SOURCES' section from Gabble which was generating a config.py. I'll remove PLUGINS_ENABLED as it's indeed useless here and merge.
Comment 8 Guillaume Desmottes 2013-09-12 11:19:18 UTC 
Merged to master; thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.