Bug 69272

Created attachment 85720 [details] [review]
bump TP_VERSION to 0.22

Created attachment 85721 [details] [review]
use tp-glib single includes

Created attachment 85722 [details] [review]
use TP_SEAL_ENABLE

Comment on attachment 85720 [details] [review]
bump TP_VERSION to 0.22

Review of attachment 85720 [details] [review]:
-----------------------------------------------------------------

++

(That's probably because Haze is the only one that already has a 'next' branch, so someone did this work already.)

Comment on attachment 85721 [details] [review]
use tp-glib single includes

Review of attachment 85721 [details] [review]:
-----------------------------------------------------------------

++

Comment on attachment 85722 [details] [review]
use TP_SEAL_ENABLE

Review of attachment 85722 [details] [review]:
-----------------------------------------------------------------

::: src/connection.c
@@ +510,5 @@
>      g_return_val_if_fail (self->account != NULL, FALSE);
>  
> +    tp_base_connection_set_self_handle (base, tp_handle_ensure (contact_handles,
> +        purple_account_get_username (self->account), NULL, error));
> +    if (tp_base_connection_get_self_handle (base) == 0)

The tp_handle_ensure() should really be separate, and done first.

I'd forgotten that Haze has StreamedMedia. :-(

Created attachment 85726 [details] [review]
use TP_SEAL_ENABLE

(In reply to comment #7)
> I'd forgotten that Haze has StreamedMedia. :-(

Let's just nuke it. It's now like it was actually used any way.

Comment on attachment 85726 [details] [review]
use TP_SEAL_ENABLE

Review of attachment 85726 [details] [review]:
-----------------------------------------------------------------

Ship it

(In reply to comment #9)
> (In reply to comment #7)
> > I'd forgotten that Haze has StreamedMedia. :-(
> 
> Let's just nuke it. It's now like it was actually used any way.

It looks as though Pidgin implements media for XMPP (we have Gabble), MSNP (basically dead) and MXIT (sufficiently obscure that I don't know whether it even works in Telepathy)... so, yes, I'm inclined to agree.

merged to master.

Haze didn't include config.h in every file, so this was ineffective.

Created attachment 85931 [details] [review]
1/4] Finish "sealing" TpBaseConnection

Created attachment 85932 [details] [review]
2/4] haze_connection_manager_class_init: don't assign to  deprecated members

Created attachment 85933 [details] [review]
3/4] All .c files: include config.h

Created attachment 85934 [details] [review]
4/4] All .c files: include corresponding header first, after  config.h

This verifies self-containedness. It turns out contact-list was not
actually self-contained: include <libpurple/account.h> to fix that.

Comment on attachment 85931 [details] [review]
1/4] Finish "sealing" TpBaseConnection

Review of attachment 85931 [details] [review]:
-----------------------------------------------------------------

++

Comment on attachment 85932 [details] [review]
2/4] haze_connection_manager_class_init: don't assign to  deprecated members

Review of attachment 85932 [details] [review]:
-----------------------------------------------------------------

++

Comment on attachment 85933 [details] [review]
3/4] All .c files: include config.h

Review of attachment 85933 [details] [review]:
-----------------------------------------------------------------

++

Do you have a magic rune to spot/fix those?

Comment on attachment 85934 [details] [review]
4/4] All .c files: include corresponding header first, after  config.h

Review of attachment 85934 [details] [review]:
-----------------------------------------------------------------

++

(In reply to comment #20)
> Do you have a magic rune to spot/fix those?

find . -name '*.c' | xargs grep --files-without-match '\<config.h' | xargs gvim

(xargs gvim is my new favourite hammer.)