Bug 69318 - Haze: Remove old Capabilites and Presence interfaces
Summary: Haze: Remove old Capabilites and Presence interfaces
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on: 69272
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-13 13:50 UTC by Guillaume Desmottes
Modified: 2013-09-17 13:39 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
connection: stop implementing old Presence interface (1.34 KB, patch)
2013-09-13 13:51 UTC, Guillaume Desmottes 		Details | Splinter Review
connection: stop implementing old Capabilities interface (7.46 KB, patch)
2013-09-13 13:51 UTC, Guillaume Desmottes 		Details | Splinter Review
Remove the remaining half of Capabilities (11.05 KB, patch)
2013-09-17 09:39 UTC, Simon McVittie 		Details | Splinter Review
Remove StreamedMedia support (164.49 KB, patch)
2013-09-17 12:31 UTC, Simon McVittie 		Details | Splinter Review
Show Obsolete (3) View All

Description Guillaume Desmottes 2013-09-13 13:50:45 UTC 
.
Comment 1 Guillaume Desmottes 2013-09-13 13:51:10 UTC 
Created attachment 85770 [details] [review]
connection: stop implementing old Presence interface
Comment 2 Guillaume Desmottes 2013-09-13 13:51:28 UTC 
Created attachment 85771 [details] [review]
connection: stop implementing old Capabilities interface
Comment 3 Xavier Claessens 2013-09-13 15:13:49 UTC 
+1
Comment 4 Guillaume Desmottes 2013-09-16 10:34:23 UTC 
Merged to master.
Comment 5 Simon McVittie 2013-09-17 09:37:58 UTC 
It didn't all go away.
Comment 6 Simon McVittie 2013-09-17 09:39:33 UTC 
Created attachment 85954 [details] [review]
Remove the remaining half of Capabilities

We previously implemented ContactCapabilities in terms of Capabilities
flags; now we implement it in terms of PurpleMediaCaps.

---

It's going to be a lot easier to merge 'master' into 'next' when we've got rid of all this.
Comment 7 Guillaume Desmottes 2013-09-17 09:43:48 UTC 
Comment on attachment 85954 [details] [review]
Remove the remaining half of Capabilities

Review of attachment 85954 [details] [review]:
-----------------------------------------------------------------

++ but I think we should just remove the audio/video code.
Comment 8 Simon McVittie 2013-09-17 09:51:39 UTC 
(In reply to comment #7)
> ++ but I think we should just remove the audio/video code.

Sure, but I'd prefer to have that be its own commit, so people who like Mxit and Call (if such people exist) can revert it for porting to Call without getting Capabilities back.
Comment 9 Simon McVittie 2013-09-17 12:31:35 UTC 
Created attachment 85969 [details] [review]
Remove StreamedMedia support

In Pidgin, it's only implemented for XMPP (for which we have Gabble),
MSNP (which will disappear soon), and mxit (which I doubt anyone's
actually tested). Empathy can't do StreamedMedia any more, only Call,
and Telepathy 1.0 will only have Call.
Comment 10 Guillaume Desmottes 2013-09-17 12:43:10 UTC 
Comment on attachment 85969 [details] [review]
Remove StreamedMedia support

Review of attachment 85969 [details] [review]:
-----------------------------------------------------------------

++ assuming you removed all the '#ifdef ENABLE_MEDIA' blocks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.