Summary: | MC: do something about extension interfaces | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
Component: | mission-control | Assignee: | Simon McVittie <smcv> |
Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | normal | ||
Priority: | medium | Keywords: | patch |
Version: | git master | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | review? | ||
i915 platform: | i915 features: | ||
Bug Depends on: | 33101, 37380, 69446 | ||
Bug Blocks: | 70382, 71093 | ||
Attachments: |
[MC master] Update extension interfaces to their telepathy-spec 0.27.1 versions
[MC master] Remove Conditions interface Remove A.I.ExternalPasswordStorage, CM.I.AccountStorage Remove code-generation machinery |
Description
Simon McVittie
2013-09-20 12:05:02 UTC
Created attachment 86177 [details] [review] [MC master] Update extension interfaces to their telepathy-spec 0.27.1 versions No functional changes. The remaining interfaces (A.I.Conditions, CD.I.Messages) are still not in telepathy-spec at all. :-( A.I.Hidden, AM.I.Hidden: Bug #33101 CD.I.Messages: Bug #37380 A.I.ExternalPasswordStorage, CM.I.AccountStorage: Bug #33485 (but should be undrafted, unless we're just going to delete it) A.I.Conditions: Bug #24896 Comment on attachment 86177 [details] [review] [MC master] Update extension interfaces to their telepathy-spec 0.27.1 versions I merged this. Created attachment 87472 [details] [review] [MC master] Remove Conditions interface I was never sure about the design, and the supporting code was removed when I refactored connectivity for 5.16. If it's needed in future, we can bring it back, hopefully with a simpler design. --- Bringing it back is Bug #24896, which already has a simpler design (that was never implemented). Comment on attachment 87472 [details] [review] [MC master] Remove Conditions interface Review of attachment 87472 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 87472 [details] [review] [MC master] Remove Conditions interface Deleted for 5.17. Please review this first: https://bugs.freedesktop.org/show_bug.cgi?id=69446#c3 Created attachment 93056 [details] [review] Remove A.I.ExternalPasswordStorage, CM.I.AccountStorage Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33485 Bug: https://bugs.freedesktop.org/show_bug.cgi?id=44512 Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69600 Created attachment 93057 [details] [review] Remove code-generation machinery --- This seems as good a way as any to assert that we don't have any extension interfaces :-P Comment on attachment 93056 [details] [review] Remove A.I.ExternalPasswordStorage, CM.I.AccountStorage Review of attachment 93056 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 93057 [details] [review] Remove code-generation machinery Review of attachment 93057 [details] [review]: ----------------------------------------------------------------- ++ No more extension interfaces! Fixed in git for 5.17.0 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.