| Summary: | [PATCH] Fix build with drm-less Xorg | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Pino Toscano <toscano.pino> | ||||||||
| Component: | Driver/openchrome | Assignee: | Openchrome development list <openchrome-devel> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | medium | CC: | 1o5g4r8o, xavier | ||||||||
| Version: | git | ||||||||||
| Hardware: | All | ||||||||||
| OS: | other | ||||||||||
| URL: | https://bugs.debian.org/672546 | ||||||||||
| Whiteboard: | |||||||||||
| i915 platform: | i915 features: | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 98569 [details] [review] Fix build on Hurd This patch makes src/via_driver.c and src/via_memmgr.c include drm_fourcc.h which defines many DRM_* macros used in non-DRI case as well. (In reply to comment #1) > Created attachment 98569 [details] [review] [review] > Fix build on Hurd > > This patch makes src/via_driver.c and src/via_memmgr.c include drm_fourcc.h > which defines many DRM_* macros used in non-DRI case as well. I can understand the new changes in the code, but please drop the configure.ac changes and don't make my commit obsolete for no good reason, thanks. Created attachment 98570 [details] [review] Fix build on Hurd Comment on attachment 98570 [details] [review] Fix build on Hurd 12c4cb9d393e1620bfbf2e5f9ba8c6d30d3dc534 already includes drm_fourcc.h unconditionally. Thanks for the patches, they've been committed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 86222 [details] Do not require libdrm as base module On GNU/Hurd there is no libdrm available yet, and thus all of Xorg is compiled without it. The openchrome fails to build because configure checks for libdrm as part of the mandatory modules. Since libdrm is checked later in configure as optional feature in the openchrome driver, it can be removed from the list of mandatory modules.