Bug 69621 - [PATCH] Fix build with drm-less Xorg
Summary: [PATCH] Fix build with drm-less Xorg
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/openchrome (show other bugs)
Version: git
Hardware: All other
: medium normal
Assignee: Openchrome development list
QA Contact:
URL: https://bugs.debian.org/672546
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-20 18:30 UTC by Pino Toscano
Modified: 2015-01-13 18:41 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Do not require libdrm as base module (1023 bytes, text/plain)
2013-09-20 18:30 UTC, Pino Toscano
no flags Details
Fix build on Hurd (858 bytes, patch)
2014-05-06 16:00 UTC, Gabriele Giacone
no flags Details | Splinter Review
Fix build on Hurd (338 bytes, patch)
2014-05-06 16:10 UTC, Gabriele Giacone
no flags Details | Splinter Review

Description Pino Toscano 2013-09-20 18:30:32 UTC
Created attachment 86222 [details]
Do not require libdrm as base module

On GNU/Hurd there is no libdrm available yet, and thus all of Xorg is compiled without it.

The openchrome fails to build because configure checks for libdrm as part of the mandatory modules. Since libdrm is checked later in configure as optional feature in the openchrome driver, it can be removed from the list of mandatory modules.
Comment 1 Gabriele Giacone 2014-05-06 16:00:50 UTC
Created attachment 98569 [details] [review]
Fix build on Hurd

This patch makes src/via_driver.c and src/via_memmgr.c include drm_fourcc.h which defines many DRM_* macros used in non-DRI case as well.
Comment 2 Pino Toscano 2014-05-06 16:04:28 UTC
(In reply to comment #1)
> Created attachment 98569 [details] [review] [review]
> Fix build on Hurd
> 
> This patch makes src/via_driver.c and src/via_memmgr.c include drm_fourcc.h
> which defines many DRM_* macros used in non-DRI case as well.

I can understand the new changes in the code, but please drop the configure.ac changes and don't make my commit obsolete for no good reason, thanks.
Comment 3 Gabriele Giacone 2014-05-06 16:10:58 UTC
Created attachment 98570 [details] [review]
Fix build on Hurd
Comment 4 Gabriele Giacone 2014-05-08 11:58:19 UTC
Comment on attachment 98570 [details] [review]
Fix build on Hurd

12c4cb9d393e1620bfbf2e5f9ba8c6d30d3dc534 already includes drm_fourcc.h unconditionally.
Comment 5 Xavier Bachelot 2015-01-13 18:41:14 UTC
Thanks for the patches, they've been committed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.